Snow 1105629 git integration tests #865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-pczajka
requested review from
sfc-gh-turbaszek,
sfc-gh-pjob,
sfc-gh-jsikorski,
sfc-gh-astus and
sfc-gh-mraba
as code owners
sfc-gh-pczajka
force-pushed
the
SNOW-1105629-git-integration-tests
branch
from
81ccc92
to
712b07b
Compare
sfc-gh-pjob
reviewed
Mar 5, 2024
Comment on lines
+81
to
+85
| result = runner.invoke_with_connection_json( | ||
| ["git", "list-branches", sf_git_repository] | ||
| ) | ||
| assert result.exit_code == 0 | ||
| assert "main" in _filter_key(result.json, key="name") |
There was a problem hiding this comment.
HAve you considered using like to reduce the json and do explicit comparison ?
There was a problem hiding this comment.
tests_integration/test_git.py
Outdated
| ["object", "stage", "list", STAGE_NAME] | ||
| ) | ||
| assert result.exit_code == 0 | ||
| print([f["name"] for f in result.json]) |
sfc-gh-pjob
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
Changes description
Add integration tests for:
snow object git-repository *snow git fetchsnow git list-branchesandlist-tagssnow git list-filessnow git copy