Fixes for package creation and pip installs #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-install-packages
…-install-packages
…-install-packages
…-install-packages
sfc-gh-jsikorski
requested review from
sfc-gh-turbaszek,
sfc-gh-pjob,
sfc-gh-astus,
sfc-gh-mraba and
sfc-gh-pczajka
as code owners
sfc-gh-jsikorski
changed the title
| @@ -64,7 +73,7 @@ def upload(file: Path, stage: str, overwrite: bool): | |||
|
|
|||
|
|
|||
| def create(zip_name: str): | |||
| file_name = zip_name if zip_name.endswith(".zip") else f"{zip_name}.zip" | |||
| file_name = f"{get_package_name(zip_name)}.zip" | |||
There was a problem hiding this comment.
Should we moved the .zip suffix to get_package_name function?
There was a problem hiding this comment.
get_package_name is used to extract name, that we will use to resolve dependencies etc. - so for example, takes the name from github repo url, zipname etc. - it seems way too early to add .zip suffix there
…-install-packages # Conflicts: # src/snowflake/cli/plugins/snowpark/package/commands.py
…-install-packages
sfc-gh-turbaszek
approved these changes
Mar 11, 2024
…-install-packages
sfc-gh-jsikorski
deleted the
jsikorski/SNOW-1053803-fix-anaconda-check-in-install-packages
branch
sfc-gh-sichen
pushed a commit
that referenced
this pull request
Oct 17, 2024
* Added dependencies check to venv * Problem * Problem2 * Fixed problem * Cleanup * Corrected github installs * Corrected lib path * added release notes * fixes * fixes * fixes * fixes * Added native libraries option * Added native libraries option * Snapshot update * Snapshot update * Fixes * After merge fixes * Minor * fixes * Updates * Performance update * Test fix * windows fix * windows fix * windows fix * windows fix * windows fix * windows fix * windows fix * windows fix * fixed tests * fixed tests * Fixes after review * Fixes after review * Fixes * Fixes * Fixes * Fixes * Fixes * Fixes * Fixes * Fixes * Replaced deprecated flags * Replaced deprecated flags * Replaced deprecated flags * Replaced deprecated flags * Fix for encoding * Fix for encoding * Fix for encoding * Fix for encoding * Fix for encoding * Started cleaning * Cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
Changes description
*Tweaked package creation mechanism in
snow snowpark package create- now we check for minimal required version, not the latest installed by pip, to reduce the size of uploaded packages (and problems mentioned in #763)Fixes: #763 , #122 , #116 (probably was fixed before, but now confirmed)