Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1019480-sql-filter-nonsql-statements: strip comments from stream… #700

Merged
merged 5 commits into from
Jan 31, 2024
Merged

SNOW-1019480-sql-filter-nonsql-statements: strip comments from stream… #700

merged 5 commits into from
Jan 31, 2024

Conversation

sfc-gh-mraba
Copy link
Contributor

@sfc-gh-mraba sfc-gh-mraba commented Jan 29, 2024 •
edited
Loading

…d queries

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • I've added or updated automated unit tests to verify correctness of my new code.
  • I've added or updated integration tests to verify correctness of my new code.
  • I've confirmed that my changes are working by executing CLI's commands manually.
  • I've confirmed that my changes are up-to-date with the target branch.
  • I've described my changes in the release notes.
  • I've described my changes in the section below.

Changes description

Enabled removal of comments when using split_statements

@sfc-gh-mraba sfc-gh-mraba self-assigned this Jan 29, 2024
@sfc-gh-mraba sfc-gh-mraba force-pushed the SNOW-1019480-sql-filter-nonsql-statements branch from 3e6291f to e1cc1d4 Compare January 31, 2024 08:12
@sfc-gh-mraba sfc-gh-mraba marked this pull request as ready for review January 31, 2024 08:41
sfc-gh-astus
sfc-gh-astus reviewed Jan 31, 2024
View reviewed changes
tests_integration/test_sql.py
[
{"1": 1},
],
]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need integration test for it? We could check what query we passed it in unit test

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With unit test we mock the connection and response.
Doing so will not test for server side error with invalid input.

@sfc-gh-mraba sfc-gh-mraba merged commit 5e0052b into main Jan 31, 2024
16 checks passed
@sfc-gh-mraba sfc-gh-mraba deleted the SNOW-1019480-sql-filter-nonsql-statements branch January 31, 2024 09:08
sfc-gh-sichen pushed a commit that referenced this pull request Oct 17, 2024
@sfc-gh-mraba
SNOW-1019480-sql-filter-nonsql-statements: strip comments from stream… (
4819c29 
#700)

* SNOW-1019480-sql-filter-nonsql-statements: strip comments from streamed queries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-astus sfc-gh-astus sfc-gh-astus left review comments

@sfc-gh-turbaszek sfc-gh-turbaszek sfc-gh-turbaszek approved these changes

@sfc-gh-pjob sfc-gh-pjob Awaiting requested review from sfc-gh-pjob

@sfc-gh-jsikorski sfc-gh-jsikorski Awaiting requested review from sfc-gh-jsikorski

@sfc-gh-pczajka sfc-gh-pczajka Awaiting requested review from sfc-gh-pczajka

Assignees

@sfc-gh-mraba sfc-gh-mraba

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-mraba @sfc-gh-turbaszek @sfc-gh-astus