Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed metric_level field from response #1880

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Removed metric_level field from response #1880

merged 1 commit into from
Nov 22, 2024

Conversation

sfc-gh-astus
Copy link
Contributor

@sfc-gh-astus sfc-gh-astus commented Nov 21, 2024 •
edited
Loading

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • I've added or updated automated unit tests to verify correctness of my new code.
  • I've added or updated integration tests to verify correctness of my new code.
  • I've confirmed that my changes are working by executing CLI's commands manually on MacOS.
  • I've confirmed that my changes are working by executing CLI's commands manually on Windows.
  • I've confirmed that my changes are up-to-date with the target branch.
  • I've described my changes in the release notes.
  • I've described my changes in the section below.

Changes description

Removed metric_level field from response

@sfc-gh-astus sfc-gh-astus requested a review from a team as a code owner November 21, 2024 15:51
sfc-gh-melnacouzi
sfc-gh-melnacouzi reviewed Nov 22, 2024
View reviewed changes
tests_integration/nativeapp/test_version.py
@@ -375,6 +375,8 @@ def test_nativeapp_version_create_package_no_magic_comment(
for row in actual.json:
# Remove date field
row.pop("created_on", None)
# Remove metric_level field
row.pop("metric_level", None)
Copy link
Contributor

@sfc-gh-melnacouzi sfc-gh-melnacouzi Nov 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved - assuming we can't snapshot this field due to variability.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't.

@sfc-gh-astus sfc-gh-astus merged commit f5dec8c into main Nov 22, 2024
19 checks passed
@sfc-gh-astus sfc-gh-astus deleted the fix-qa-tests branch November 22, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-melnacouzi sfc-gh-melnacouzi sfc-gh-melnacouzi approved these changes

@sfc-gh-bdufour sfc-gh-bdufour sfc-gh-bdufour approved these changes

@sfc-gh-jsikorski sfc-gh-jsikorski sfc-gh-jsikorski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-astus @sfc-gh-jsikorski @sfc-gh-bdufour @sfc-gh-melnacouzi