Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make manifest optional in application package pdfV2 #1859

Merged
merged 4 commits into from
Nov 18, 2024
Merged

Make manifest optional in application package pdfV2 #1859

merged 4 commits into from
Nov 18, 2024

Conversation

sfc-gh-pjafari
Copy link
Contributor

@sfc-gh-pjafari sfc-gh-pjafari commented Nov 14, 2024 •
edited
Loading

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • I've added or updated automated unit tests to verify correctness of my new code.
  • I've added or updated integration tests to verify correctness of my new code.
  • I've confirmed that my changes are working by executing CLI's commands manually on MacOS.
  • I've confirmed that my changes are working by executing CLI's commands manually on Windows.
  • I've confirmed that my changes are up-to-date with the target branch.
  • I've described my changes in the release notes.
  • I've described my changes in the section below.

Changes description

  • make manifest field optional in pdfV2 definition of application package
  • don't generate manifest field in v1-to-v2 conversions

Change to snowflake-cli-templates to exclude the field when cli version >= 3.2.0
snowflakedb/snowflake-cli-templates#15

@sfc-gh-pjafari sfc-gh-pjafari marked this pull request as ready for review November 14, 2024 19:21
@sfc-gh-pjafari sfc-gh-pjafari requested review from a team as code owners November 14, 2024 19:21
@sfc-gh-pjafari sfc-gh-pjafari enabled auto-merge (squash) November 15, 2024 16:43
@sfc-gh-pjafari sfc-gh-pjafari merged commit d7862a3 into main Nov 18, 2024
19 checks passed
@sfc-gh-pjafari sfc-gh-pjafari deleted the pj-SNOW-1797944 branch November 18, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-melnacouzi sfc-gh-melnacouzi sfc-gh-melnacouzi approved these changes

@sfc-gh-astus sfc-gh-astus sfc-gh-astus approved these changes

@sfc-gh-bdufour sfc-gh-bdufour sfc-gh-bdufour left review comments

Assignees
No one assigned
Labels
3.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-pjafari @sfc-gh-astus @sfc-gh-bdufour @sfc-gh-melnacouzi