Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

instrument NADE commands using metric spans #1844

Merged
merged 30 commits into from
Nov 22, 2024
Merged

instrument NADE commands using metric spans #1844

merged 30 commits into from
Nov 22, 2024

Commits on Nov 8, 2024

  1. draft PR for feedback on instrumentation

    @sfc-gh-mchok
    sfc-gh-mchok committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    a2a833e View commit details
    Browse the repository at this point in the history

  2. remove changes on loggers

    @sfc-gh-mchok
    sfc-gh-mchok committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    46a3028 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into mchok-metric-spans-instrument-nade-cmds

    @sfc-gh-mchok
    sfc-gh-mchok authored Nov 8, 2024
    Configuration menu
    Copy the full SHA
    cf3a339 View commit details
    Browse the repository at this point in the history

  4. extract enum value for proper key to message dict

    @sfc-gh-mchok
    sfc-gh-mchok committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    d26af10 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2024

  1. write custom decorator for spans, add tests

    @sfc-gh-mchok
    sfc-gh-mchok committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    6b3d12e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into mchok-metric-spans-instrument-nade-cmds

    @sfc-gh-mchok
    sfc-gh-mchok authored Nov 11, 2024
    Configuration menu
    Copy the full SHA
    ca990d4 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. rename spans as logical steps, remove extra param from console phase,… 

    … un-parametrize tests, merge test files to keep with covention
    @sfc-gh-mchok
    sfc-gh-mchok committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    4edd8b2 View commit details
    Browse the repository at this point in the history

  2. adjust tests for new spans

    @sfc-gh-mchok
    sfc-gh-mchok committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    f99a275 View commit details
    Browse the repository at this point in the history

  3. time.monotonic() -> time.perf_counter() for proper ordering on windows

    @sfc-gh-mchok
    sfc-gh-mchok committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    db00d94 View commit details
    Browse the repository at this point in the history

  4. add span for getting snowsight url since it is a blind spot

    @sfc-gh-mchok
    sfc-gh-mchok committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    84209f0 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2024

  1. Merge branch 'main' into mchok-metric-spans-instrument-nade-cmds

    @sfc-gh-mchok
    sfc-gh-mchok authored Nov 13, 2024
    Configuration menu
    Copy the full SHA
    506bae2 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into mchok-metric-spans-instrument-nade-cmds

    @sfc-gh-mchok
    sfc-gh-mchok authored Nov 13, 2024
    Configuration menu
    Copy the full SHA
    7846c43 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin' into mchok-metric-spans-instrum… 

    …ent-nade-cmds
    @sfc-gh-mchok
    sfc-gh-mchok committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    ec44e0c View commit details
    Browse the repository at this point in the history

  4. add event sharing counters from merge conflicts to new file

    @sfc-gh-mchok
    sfc-gh-mchok committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    d5e2376 View commit details
    Browse the repository at this point in the history

  5. add span for create_or_upgrade_app to address blind spot

    @sfc-gh-mchok
    sfc-gh-mchok committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    15955f7 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. Merge branch 'main' into mchok-metric-spans-instrument-nade-cmds

    @sfc-gh-mchok
    sfc-gh-mchok authored Nov 14, 2024
    Configuration menu
    Copy the full SHA
    1b1d99a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into mchok-metric-spans-instrument-nade-cmds

    @sfc-gh-mchok
    sfc-gh-mchok authored Nov 14, 2024
    Configuration menu
    Copy the full SHA
    a32a21b View commit details
    Browse the repository at this point in the history

  3. adjust span names for consistency

    @sfc-gh-mchok
    sfc-gh-mchok committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    b77d135 View commit details
    Browse the repository at this point in the history

  4. add docstring for entity action span decorator

    @sfc-gh-mchok
    sfc-gh-mchok committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    cef9f19 View commit details
    Browse the repository at this point in the history

  5. fix spans bundle test

    @sfc-gh-mchok
    sfc-gh-mchok committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    8a45192 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2024

  1. Merge branch 'main' into mchok-metric-spans-instrument-nade-cmds

    @sfc-gh-mchok
    sfc-gh-mchok authored Nov 18, 2024
    Configuration menu
    Copy the full SHA
    bf8cf5b View commit details
    Browse the repository at this point in the history

  2. sort spans deterministically by creation order

    @sfc-gh-mchok
    sfc-gh-mchok committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    ae43f25 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into mchok-metric-spans-instrument-nade-cmds

    @sfc-gh-mchok
    sfc-gh-mchok authored Nov 18, 2024
    Configuration menu
    Copy the full SHA
    93e5dc9 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into mchok-metric-spans-instrument-nade-cmds

    @sfc-gh-mchok
    sfc-gh-mchok authored Nov 18, 2024
    Configuration menu
    Copy the full SHA
    bfc4f21 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into mchok-metric-spans-instrument-nade-cmds

    @sfc-gh-mchok
    sfc-gh-mchok authored Nov 18, 2024
    Configuration menu
    Copy the full SHA
    5e1e38c View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2024

  1. Merge branch 'main' into mchok-metric-spans-instrument-nade-cmds

    @sfc-gh-mchok
    sfc-gh-mchok authored Nov 19, 2024
    Configuration menu
    Copy the full SHA
    348aac2 View commit details
    Browse the repository at this point in the history

  2. only one sort, remove counter

    @sfc-gh-mchok
    sfc-gh-mchok committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    c618da6 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2024

  1. Merge branch 'main' into mchok-metric-spans-instrument-nade-cmds

    @sfc-gh-mchok
    sfc-gh-mchok authored Nov 20, 2024
    Configuration menu
    Copy the full SHA
    2fbdcb6 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into mchok-metric-spans-instrument-nade-cmds

    @sfc-gh-mchok
    sfc-gh-mchok authored Nov 20, 2024
    Configuration menu
    Copy the full SHA
    05d81a9 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2024

  1. update comment for span decorator to reflect new method name

    @sfc-gh-mchok
    sfc-gh-mchok committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    e96a0ee View commit details
    Browse the repository at this point in the history