Skip to content

Commit

Permalink
Fixes after review
Browse files Browse the repository at this point in the history
  • Loading branch information
sfc-gh-jsikorski committed Mar 7, 2024
1 parent 9216782 commit e0db3fd
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
1 change: 0 additions & 1 deletion RELEASE-NOTES.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
* Adding `--image-name` option for image name argument in `spcs image-repository list-tags` for consistency with other commands.
* Fixed errors during `spcs image-registry login` not being formatted correctly.
* Project definition no longer accept extra fields. Any extra field will cause an error.
* Project definition no longer accept extra fields. Any extra field will cause an error.

# v2.1.0

Expand Down
1 change: 0 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ dependencies = [
"requirements-parser==0.5.0",
"setuptools==69.1.1",
"snowflake-connector-python[secure-local-storage]==3.7.1",
"strictyaml==1.7.3",
"tomlkit==0.12.3",
"typer==0.9.0",
"urllib3>=1.21.1,<2.3",
Expand Down
4 changes: 2 additions & 2 deletions src/snowflake/cli/api/project/schemas/native_app/package.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class Package(UpdatableModel):
default=None,
)
name: Optional[str] = IdentifierField(
title="Name of the application created when you run the snow app run command", # TODO: this description seems duplicated, is it ok?
title="Name of the application package created when you run the snow app run command",
default=None,
)
warehouse: Optional[str] = IdentifierField(
Expand All @@ -35,6 +35,6 @@ class Package(UpdatableModel):
def validate_scripts(cls, input_list):
if len(input_list) != len(set(input_list)):
raise ValueError(
"Scripts field should contain unique values. Check the list for duplicates and try again"
"package.scripts field should contain unique values. Check the list for duplicates and try again"
)
return input_list
4 changes: 3 additions & 1 deletion src/snowflake/cli/api/project/schemas/project_definition.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,9 @@

class ProjectDefinition(UpdatableModel):
definition_version: int = Field(
title="Version of the project definition schema, which is currently 1"
title="Version of the project definition schema, which is currently 1",
ge=1,
le=1,
)
native_app: Optional[NativeApp] = Field(
title="Native app definitions for the project", default=None
Expand Down

0 comments on commit e0db3fd

Please sign in to comment.