Add app templates #10
Merged
+1,534
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-bdufour
force-pushed
the
add-app-templates
branch
from
7b620d5
to
d4da38e
Compare
sfc-gh-fcampbell
previously approved these changes
Sep 26, 2024
sfc-gh-pczajka
previously approved these changes
Sep 30, 2024
|
LGTM from template syntax point of view, please wait with merging for one more CLI approval |
Comment on lines
+6
to
+8
| - name: project_name | ||
| prompt: "Project identifier" | ||
| default: my_native_app_project |
There was a problem hiding this comment.
Is there any strong opinion on using "project" for this variable?
There was a problem hiding this comment.
snow init still says it "creates a project directory", so I figured that was the right term.
sfc-gh-turbaszek
dismissed stale reviews from sfc-gh-pczajka and sfc-gh-fcampbell
The base branch was changed.
sfc-gh-turbaszek
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported native app templates from https://github.com/snowflakedb/native-apps-templates