Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update lock package #571

Merged
merged 1 commit into from
Aug 1, 2024
Merged

chore: update lock package #571

merged 1 commit into from
Aug 1, 2024

Conversation

wa0x6e
Copy link
Contributor

@wa0x6e wa0x6e commented Aug 1, 2024

Summary

This is continuation of #538

Instead of fixing the issue from sx side, we fixed the issue on the lock package

How to test

TLDR: instead of seeing an invalid connected state, it should just show the "Connect button" as if you're unlogged when metamask is locked on subsequent page refresh.

@wa0x6e wa0x6e requested review from Sekhmet and ChaituVR August 1, 2024 05:14
@Sekhmet
Copy link
Member

Sekhmet commented Aug 1, 2024

Following those steps works: snapshot-labs/lock#114 (although it's bit weird that after closing popup it's still in loading state, can we detect that user closed the popup and get back to "Connect wallet" state).

I tried to follow those steps as well (#538) and got in broken state so this doesn't fix it it seems:
image

@wa0x6e
Copy link
Contributor Author

wa0x6e commented Aug 1, 2024

Following those steps works: snapshot-labs/lock#114 (although it's bit weird that after closing popup it's still in loading state, can we detect that user closed the popup and get back to "Connect wallet" state).

I tried to follow those steps as well (#538) and got in broken state so this doesn't fix it it seems: image

I tried to reproduce the steps to trigger the invalid logged in state, without success.

Are you able to trigger that on https://bafybeifdq4d75kupkb63jjepmiepzyy6ks57nweeitvwin7tdc4q4oxrna.on.fleek.co/#/ ?

@bonustrack
Copy link
Member

Is this also supposed to be a fix for #255?

@wa0x6e
Copy link
Contributor Author

wa0x6e commented Aug 1, 2024

No, it’s supposed to be fixed by another pr

@Sekhmet
Copy link
Member

Sekhmet commented Aug 1, 2024

Forgot to run yarn 😆

Copy link
Member

@Sekhmet Sekhmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@Sekhmet Sekhmet merged commit 405fb4f into master Aug 1, 2024
3 checks passed
@Sekhmet Sekhmet deleted the chore-update-lock-to-0-2-5 branch August 1, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants