Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unused actions #1047

Merged
merged 1 commit into from
Dec 11, 2024
Merged

refactor: remove unused actions #1047

merged 1 commit into from
Dec 11, 2024

Conversation

Sekhmet
Copy link
Member

@Sekhmet Sekhmet commented Dec 11, 2024

Summary

Removing actions that are no longer used (were replaced by updateSettings):

  • setMetadata
  • setVotingDelay
  • setMinVotingDuration
  • setMaxVotingDuration

This will reduce number of changes needed as we change behaviour of calling actions as Safe.

We leave actions in sx.js in clients as-is.

Removing actions that are no longer used (were replaced by updateSettings):
 - setMetadata
 - setVotingDelay
 - setMinVotingDuration
 - setMaxVotingDuration

This will reduce number of changes needed as we change behaviour of
calling actions as Safe.
@Sekhmet Sekhmet requested review from wa0x6e and bonustrack December 11, 2024 17:06
Copy link
Member

@bonustrack bonustrack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@Sekhmet Sekhmet merged commit e4a618e into master Dec 11, 2024
2 checks passed
@Sekhmet Sekhmet deleted the sekhmet/unused-actions branch December 11, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants