fix: force user to login only on account dependent page #1045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wa0x6e
changed the title
ChaituVR
approved these changes
Dec 11, 2024
| [() => web3.value.account, () => web3.value.authLoading], | ||
| ([account, authLoading]) => { | ||
| if (!account && !authLoading) { | ||
| modalAccountWithoutDismissOpen.value = true; |
There was a problem hiding this comment.
Maybe better to redirect to home/explore page?
There was a problem hiding this comment.
My reasoning is as follow:
user who wants these page have a direct link (bookmarks, etc…), and want their content. If not logged in, they would want to login, else it would not make sense to access these pages.
/home is different, as there’s a link from the landing page, and anyone can go there.
bonustrack
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes: https://github.com/snapshot-labs/workflow/issues/325
This PR will force prompt users to login only page depending on the current wallet (except /home).
Also fix a minor issue where logging out while on the /notifications page was not clearing the existing notifications
How to test