Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: show results on pending proposals #1044

Merged
merged 1 commit into from
Dec 11, 2024
Merged

fix: show results on pending proposals #1044

merged 1 commit into from
Dec 11, 2024

Conversation

wa0x6e
Copy link
Contributor

@wa0x6e wa0x6e commented Dec 11, 2024 •
edited
Loading

Summary

Closes: https://github.com/snapshot-labs/workflow/issues/326

This PR will show the results on pending proposals

How to test

  1. Go to an onchain/offchain pending proposals
  2. You should see the results in the sidebar

@wa0x6e wa0x6e requested a review from ChaituVR December 11, 2024 04:24
@wa0x6e wa0x6e marked this pull request as ready for review December 11, 2024 04:24
@wa0x6e
Copy link
Contributor Author

wa0x6e commented Dec 11, 2024

UI for basic choices is still too colorful, maybe we should add an opacity: 0.5 on the results, to highlight that they're not live yet

ChaituVR
ChaituVR approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@ChaituVR ChaituVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tAck

@wa0x6e wa0x6e merged commit 4172135 into master Dec 11, 2024
4 checks passed
@wa0x6e wa0x6e deleted the fix-show-result-on-pending-proposals branch December 11, 2024 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChaituVR ChaituVR ChaituVR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wa0x6e @ChaituVR