Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix page main content not taking full height #1038

Merged
merged 4 commits into from
Dec 11, 2024
Merged

fix: fix page main content not taking full height #1038

merged 4 commits into from
Dec 11, 2024

Conversation

wa0x6e
Copy link
Contributor

@wa0x6e wa0x6e commented Dec 10, 2024 •
edited
Loading

Summary

Closes: #1035

How to test

  1. Go to editor
  2. The right sidebar border should go all the way down

@wa0x6e wa0x6e requested a review from ChaituVR December 10, 2024 13:58
@wa0x6e wa0x6e marked this pull request as ready for review December 10, 2024 13:58
bonustrack
bonustrack approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@bonustrack bonustrack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@wa0x6e wa0x6e merged commit 81e0a90 into master Dec 11, 2024
4 checks passed
@wa0x6e wa0x6e deleted the fix-page-content-not-full-height branch December 11, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bonustrack bonustrack bonustrack approved these changes

@ChaituVR ChaituVR Awaiting requested review from ChaituVR

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Border of sidebar is not occupying full height in editor
2 participants
@wa0x6e @bonustrack