feat: add flash message introducing v2 #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requesting @ChaituVR for code check, still waiting for @bonustrack for UI validation |
ChaituVR
reviewed
Dec 10, 2024
There was a problem hiding this comment.
tAck for code, lets wait for approval from @bonustrack
seems bit off here 🤔 maybe because of the font?
or should be centered with padding-left 10px?
Not a design expert 🙈 can ignore this comment
|
@bonustrack Any more improvement left to add ? Else we should release this feat asap, as the more we wait, the less useful it will be |
|
Design looks good, but I've just noticed the link to v1 doesn't work for me. Also the popup should appear even on the landing page. |
|
I'm merging this for now, we can fix the issue with v1 link in another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes: https://github.com/snapshot-labs/workflow/issues/318
This PR adds a new flash message on the bottom right corner, introducing the v2, as well as show link to go back to v1
Once closed, flash message will not appear again (state saved in localStorage)
How to test