feat: add follows count from EFP #1017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChaituVR
approved these changes
Dec 3, 2024
| userMetadata.loading = false; | ||
| userMetadata.loaded = true; | ||
| } catch (e) { | ||
| userMetadata.loading = false; |
There was a problem hiding this comment.
maybe we should log error to understand what is going wrong, just in case
Suggested change
| userMetadata.loading = false; | |
| console.log(e); | |
| userMetadata.loading = false; |
Comment on lines
+6
to
+8
| addressOrENS: string | ||
| ): Promise<{ followers_count: number; following_count: number }> { | ||
| if (!isAddress(addressOrENS)) return Promise.reject('Invalid address'); |
There was a problem hiding this comment.
Bit confusing that we named param as addressOrENS and rejecting if it is not address
maybe we can rename param to address
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show followings and followers count on user main profile using EFP.
How to test
For EVM user: http://localhost:8080/#/profile/0x2332a02fea96b42fc3095ae7c73963980db9331b
For Starknet user (incompatible): http://localhost:8080/#/sn:0x009fedaf0d7a480d21a27683b0965c0f8ded35b3f1cac39827a25a06a8a682a4/profile/0x04ea765e7bfb966f8420fb21b649cddae0641345138590564bb449e36b32c527