-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add email subscription #1081
Open
wa0x6e
wants to merge
14
commits into
master
Choose a base branch
from
feat-ad-email-subscriptions-to-user
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
a61292a
feat: add-email-subscription-to-profile
wa0x6e ed5304c
fix: move out email subscription creation from profile
wa0x6e 37a0014
feat: add Subscription schema
wa0x6e 977a8c5
refactor: move emailSubscription to subscription
wa0x6e 071172e
feat: add unsubscription type
wa0x6e f8d5630
refactor: rename unsubscription to delete-subscription
wa0x6e 24edc54
feat: add delete-subscription to signer
wa0x6e 8a694b2
revert: revert unrelated changes
wa0x6e 7a045aa
fix: add missing types
wa0x6e 6cac76d
feat: support subscription in sign
wa0x6e 8fdef57
fix: add email validation to subscription value type
wa0x6e 086ad9e
refactor: rename subscription to email-subscription
wa0x6e 79b26ef
Merge branch 'master' into feat-ad-email-subscriptions-to-user
wa0x6e 91879d9
fix: properties can be optional
wa0x6e File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
{ | ||
"$schema": "http://json-schema.org/draft-07/schema#", | ||
"$ref": "#/definitions/EmailSubscription", | ||
"definitions": { | ||
"EmailSubscription": { | ||
"title": "EmailSubscription", | ||
"type": "object", | ||
"properties": { | ||
"email": { | ||
"type": "string", | ||
"format": "email", | ||
"title": "value", | ||
"maxLength": 256 | ||
}, | ||
"subscriptions": { | ||
"title": "subscriptions", | ||
"type": "array", | ||
"items": { | ||
"type": "string", | ||
"enum": ["summary", "newProposal", "closedProposal"] | ||
} | ||
} | ||
}, | ||
"required": [], | ||
"additionalProperties": false | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
{ | ||
"type": "email", | ||
"value": "[email protected]", | ||
"metadata": "['summary', 'newProposal']" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,6 +7,7 @@ import spaceStarknetDelegation from './examples/space-starknet-delegation.json'; | |
import proposalTurbo from './examples/proposal-turbo.json'; | ||
import vote from './examples/vote.json'; | ||
import profile from './examples/profile.json'; | ||
import subscription from './examples/subscription.json'; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. i think we should rename this file also to avoid confusions |
||
import statement from './examples/statement.json'; | ||
import alias from './examples/alias.json'; | ||
import schemas from '../src/schemas'; | ||
|
@@ -24,6 +25,11 @@ describe.each([ | |
{ schemaType: 'proposal', schema: schemas.proposal, example: proposal }, | ||
{ schemaType: 'vote', schema: schemas.vote, example: vote }, | ||
{ schemaType: 'profile', schema: schemas.profile, example: profile }, | ||
{ | ||
schemaType: 'subscription', | ||
schema: schemas.subscription, | ||
example: subscription | ||
}, | ||
{ schemaType: 'statement', schema: schemas.statement, example: statement }, | ||
{ schemaType: 'zodiac', schema: schemas.zodiac, example: space }, | ||
{ schemaType: 'alias', schema: schemas.alias, example: alias } | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure what this file is for 🤔