Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(release-to-candidate): Support projects that doesn't specify the version property #46

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Commits on Aug 22, 2024

  1. feat(release-to-candidate): Support projects that doesn't specify the…

    … `version` property
    
    It is possible that the Snapcraft project doesn't specify the `version`
    property in the snapcraft.yaml, instead setting the snap version string
    via the `craftctl set version=_version` mechanism.  In this case the
    parse-snapcraft-yaml job will set the version variable to `null`, making
    the release-to-candidate job unable to detect the built snap due to
    filename mismatch.
    
    This patch enhances the release-to-candidate job so that the built
    snap will still be matched via filename matching.
    
    Signed-off-by: 林博仁(Buo-ren Lin) <[email protected]>
    brlin-tw committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    81969af View commit details
    Browse the repository at this point in the history
  2. lint: Avoid triggering SC2153 linter error

    Signed-off-by: 林博仁(Buo-ren Lin) <[email protected]>
    brlin-tw committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    79b567a View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2024

  1. fixup! feat(release-to-candidate): Support projects that doesn't spec…

    …ify the `version` property
    
    Signed-off-by: 林博仁(Buo-ren Lin) <[email protected]>
    brlin-tw committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    c923fd1 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. Fix SC2295 linting error

    Avoid parameter expansion result being treated as a filename pattern.
    
    Signed-off-by: 林博仁(Buo-ren Lin) <[email protected]>
    brlin-tw committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    d565b12 View commit details
    Browse the repository at this point in the history