feat: Add support for building + releasing core24 based snaps #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
core24 uses the `platforms` key for specifying the architecture of the snap rather than `architectures`. This commit adds a conditional that properly handles the `platforms` key when determining which arches to build for. Signed-off-by: Jason C. Nucciarone <[email protected]>
`core24` supports using the platform flag with the Launchpad remote-builders. This commit adds a conditional that checks if the base is core24. If the base is core24, it uses the `--platfrom` flag rather than the build-for flag. Signed-off-by: Jason C. Nucciarone <[email protected]>
jnsgruk
approved these changes
May 23, 2024
|
@jnsgruk I'm going to use it with the Slurm snap: charmed-hpc/slurm-snap#2 Upgraded to core24 since it means that I can drop the AMD GPU drivers that I am pulling from a PPA and can instead use the packages available in archive. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
core24 now uses the
platformskeyword for specifying the build architecture for snaps rather than thearchitectureskeyword. This pull request updates the get-architectures and release-to-candidate actions to support using theplatformstop-level key to determine which arches to build the snap for.Also, the remote-build command, when building core24 snaps, will use the
--platformsflag rather than the--build-forflag.