Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow specification of app inside snap to screenshot #32

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

jnsgruk
Copy link
Member

@jnsgruk jnsgruk commented Feb 9, 2024

Allows the specification of an application name to execute inside the snap when taking screenshots.

Helps when the snap has a different "app name" to "snap name". E.g. the sublime-text snap only has an app named subl defined, which led to this failure in CI: https://github.com/snapcrafters/sublime-text/actions/runs/7844422700/job/21407033718#step:2:292

@jnsgruk jnsgruk requested review from a team and removed request for a team February 9, 2024 13:30
@jnsgruk jnsgruk requested a review from a team February 9, 2024 13:31
@jnsgruk jnsgruk merged commit 1472dab into snapcrafters:main Feb 9, 2024
1 check passed
@jnsgruk jnsgruk deleted the screenshot-app-name branch February 9, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants