Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: Do not use deprecated ghvmctl snap commands #22

Merged
merged 1 commit into from
Dec 27, 2023
Merged

cleanup: Do not use deprecated ghvmctl snap commands #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions get-screenshots/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,13 +71,13 @@ runs:
if ls manifest-amd64.yaml &>/dev/null; then
rev="$(yq -r '.revision' manifest-amd64.yaml)"
echo "Installing snap revision '${rev}' from build manifest"
ghvmctl install-snap "${snap_name}" --revision "${rev}"
ghvmctl snap-install "${snap_name}" --revision "${rev}"
else
echo "Installing snap from 'latest/${{ inputs.channel}}'"
ghvmctl install-snap "${snap_name}" --channel "latest/${{ inputs.channel }}"
ghvmctl snap-install "${snap_name}" --channel "latest/${{ inputs.channel }}"
fi

ghvmctl run-snap "${snap_name}"
ghvmctl snap-run "${snap_name}"
sleep 60

- name: Gather screenshots
Expand Down
4 changes: 2 additions & 2 deletions setup-ghvmctl/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ jobs:
run: |
# Prepare the VM, install and launch the app on the desktop
ghvmctl prepare
ghvmctl install-snap signal-desktop --channel candidate
ghvmctl run-snap signal-desktop
ghvmctl snap-install signal-desktop --channel candidate
ghvmctl snap-run signal-desktop

- name: Take screenshots & output logs
run: |
Expand Down