fix: specify snapcraft-project-root instead of snapcraft-yaml-path #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnsgruk
force-pushed
the
fix-snap-build-action
branch
from
38f042e
to
a500191
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes our current build issues where we were passing the path of a
snapcraft.yamltosnapcore/action-build, and indeed tosnapcraft remote-build.This is an API change, but I don't think we'd actually adopted the new option anywhere yet, so we're clear! 😅
The logic here is that if you have a non-standard location for your snapcraft project, the input you provide is the
snapcraft-project-root- or put simply the path from the root of the repo where you'd usually runsnapcraft packyourself. From the project root, there are only 4 valid paths to thesnapcraft.yaml, which we can compute easily once we have the project root.Tested each workflow in a separate repo, both with and without specifying the new option, and they all seem to check out.