Adds Webpack configuration for bundling our JavaScript #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using Webpack module bunlder we are now able to minify the JavaScript files. We would need to change the structure of our JavaScript source files in the future but at the moment we'll generate the new minified JavaScript and add it to `virtualhosts/www/javascript/`. The current setup, doesn't require any change on our JavaScript only changes in the directory structure.
Configured Webpack to export a library with exports on the `window` object so the scripts' exported functions and variables are accessible on the global scope. By doing this we avoid changing the inline scripts on the HTML templates. TODO: Add production configuration to Webpack.
We are now able to generate a minified version for production and development for our JavaScript files. The development script leaves keeps a watch on the files, if anything changes Webpack updates the files so we don't have to regenerate them manualy while developing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #251
This commit includes the basic configuration for Yarn and Webpack to provide minification of our JavaScript code and in the future support for modern JavaScript through transpilation with Babel.