Service object updates (#88)

* remove barrel file for api service layer * update return signatures for clarity in api service layer * remove references to barrel file
snac-cooperative · Sep 19, 2024 · 022f26f · 022f26f
1 parent 3936b96
commit 022f26f
Show file tree

Hide file tree

Showing 6 changed files with 19 additions and 24 deletions.
diff --git a/resources/js/api/ConceptService.js b/resources/js/api/ConceptService.js
@@ -1,7 +1,7 @@
 import axios from 'axios';
 
 const apiClient = axios.create({
-  baseURL: `api/concepts`,
+  baseURL: `/api/concepts`,
 });
 
 export default {
@@ -17,7 +17,7 @@ export default {
       });
       return [null, data];
     } catch (error) {
-      return [error];
+      return [error, null];
     }
   },
 
@@ -26,7 +26,7 @@ export default {
       const { data } = await apiClient.get(`/${conceptId}`);
       return [null, data];
     } catch (error) {
-      return [error];
+      return [error, null];
     }
   },
 
@@ -35,7 +35,7 @@ export default {
       const { data } = await apiClient.post('', conceptData);
       return [null, data];
     } catch (error) {
-      return [error];
+      return [error, null];
     }
   },
 
@@ -44,7 +44,7 @@ export default {
       const { data } = await apiClient.delete(`/${conceptId}`);
       return [null, data];
     } catch (error) {
-      return [error];
+      return [error, null];
     }
   },
 };
diff --git a/resources/js/api/ConceptSourceService.js b/resources/js/api/ConceptSourceService.js
@@ -1,7 +1,7 @@
 import axios from 'axios';
 
 const apiClient = axios.create({
-  baseURL: `api/concept_sources`,
+  baseURL: `/api/concept_sources`,
 });
 
 export default {
@@ -17,7 +17,7 @@ export default {
       });
       return [null, data];
     } catch (error) {
-      return [error];
+      return [error, null];
     }
   },
 
@@ -26,7 +26,7 @@ export default {
       const { data } = await apiClient.get(`/${conceptSourceId}`);
       return [null, data];
     } catch (error) {
-      return [error];
+      return [error, null];
     }
   },
 
@@ -35,7 +35,7 @@ export default {
       const { data } = await apiClient.post('', conceptSourceData);
       return [null, data];
     } catch (error) {
-      return [error];
+      return [error, null];
     }
   },
 
@@ -47,7 +47,7 @@ export default {
       );
       return [null, data];
     } catch (error) {
-      return [error];
+      return [error, null];
     }
   },
 
@@ -56,7 +56,7 @@ export default {
       const { data } = await apiClient.delete(`/${conceptSourceId}`);
       return [null, data];
     } catch (error) {
-      return [error];
+      return [error, null];
     }
   },
 };
diff --git a/resources/js/api/TermService.js b/resources/js/api/TermService.js
@@ -1,7 +1,7 @@
 import axios from 'axios';
 
 const apiClient = axios.create({
-  baseURL: `api/terms`,
+  baseURL: `/api/terms`,
 });
 
 export default {
@@ -17,7 +17,7 @@ export default {
       });
       return [null, data];
     } catch (error) {
-      return [error];
+      return [error, null];
     }
   },
 
@@ -26,7 +26,7 @@ export default {
       const { data } = await apiClient.get(`/${termId}`);
       return [null, data];
     } catch (error) {
-      return [error];
+      return [error, null];
     }
   },
 
@@ -35,7 +35,7 @@ export default {
       const { data } = await apiClient.post('', termData);
       return [null, data];
     } catch (error) {
-      return [error];
+      return [error, null];
     }
   },
 
@@ -44,7 +44,7 @@ export default {
       const { data } = await apiClient.patch(`/${termId}`, termData);
       return [null, data];
     } catch (error) {
-      return [error];
+      return [error, null];
     }
   },
 
@@ -53,7 +53,7 @@ export default {
       const { data } = await apiClient.delete(`/${termId}`);
       return [null, data];
     } catch (error) {
-      return [error];
+      return [error, null];
     }
   },
 };
diff --git a/resources/js/api/index.js b/resources/js/api/index.js
diff --git a/resources/js/components/Concept/Create.vue b/resources/js/components/Concept/Create.vue
@@ -87,7 +87,7 @@ import {
   BFormInvalidFeedback,
 } from 'bootstrap-vue';
 import { categories } from '../../config/catgegories';
-import { ConceptService } from '../../api';
+import ConceptService from '../../api/ConceptService';
 
 export default {
   data() {

diff --git a/resources/js/components/Concept/List.vue b/resources/js/components/Concept/List.vue
@@ -87,7 +87,7 @@ import {
   BPagination,
   BTable,
 } from 'bootstrap-vue';
-import { ConceptService } from '../../api';
+import ConceptService from '../../api/ConceptService';
 import { sortBy } from 'lodash';
 
 export default {