Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Arya #94

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Add Arya #94

merged 2 commits into from
Feb 21, 2024

Conversation

WarriorGallade
Copy link
Contributor

No description provided.

Comment on lines 298 to 306
onEnd(target) {
const activePokemon = this.getAllActive();
for (const a of activePokemon) {
if (a.name === "Arya" && a.side !== target.side) {
this.boost({spa: -2}, a);
break;
}
}
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you dont need a for loop here, since onEnd takes a pokemon arg (pokemon being the volatile holder)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's the problem though, i checked this during testing. removing the loop and having just the debuff in onEnd applies it to the opponent, not the user.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second looksee, thats because volatileStatus is being applied to the opponent, not the user

@HisuianZoroark HisuianZoroark merged commit d93299c into smogon:master Feb 21, 2024
1 check passed
KrisXV pushed a commit that referenced this pull request Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants