Skip to content

Commit

Permalink
Apply Kris suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Kris Johnson <[email protected]>
  • Loading branch information
WarriorGallade and KrisXV authored Feb 19, 2024
1 parent 4a64ada commit 412e688
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 7 deletions.
2 changes: 1 addition & 1 deletion data/mods/gen9ssb/abilities.ts
Original file line number Diff line number Diff line change
Expand Up @@ -705,7 +705,7 @@ export const Abilities: {[k: string]: ModdedAbilityData} = {
name: "Low Tide, High Tide",
onStart(source) {
this.field.addPseudoWeather('gravity', source);
},
},
onTryHit(target, source, move) {
if (target !== source && move.type === 'Water') {
this.add('-immune', target, '[from] ability: Low Tide, High Tide');
Expand Down
9 changes: 4 additions & 5 deletions data/mods/gen9ssb/conditions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -588,7 +588,7 @@ export const Conditions: {[k: string]: ModdedConditionData & {innateName?: strin
shortDesc: "User will heal 33% of their max HP on switch-out.",
},
lunell: {
noCopy: true,
noCopy: true,
onStart() {
this.add(`c:|${getName('Lunell')}|vapowo`);
},
Expand All @@ -597,7 +597,7 @@ export const Conditions: {[k: string]: ModdedConditionData & {innateName?: strin
},
onFaint() {
this.add(`c:|${getName('Lunell')}|*sad vaporeon noises*`);
},
},
},
madmonty: {
noCopy: true,
Expand Down Expand Up @@ -1310,7 +1310,7 @@ export const Conditions: {[k: string]: ModdedConditionData & {innateName?: strin
}
},
onFieldResidualOrder: 27,
onFieldResidualSubOrder: 2,
onFieldResidualSubOrder: 2,
onFieldEnd() {
this.add('-fieldend', 'move: Gravity');
const activePokemon = this.getAllActive();
Expand All @@ -1320,9 +1320,8 @@ export const Conditions: {[k: string]: ModdedConditionData & {innateName?: strin
break;
}
}
},
},
},

raindance: {
inherit: true,
onWeatherModifyDamage(damage, attacker, defender, move) {
Expand Down
1 change: 0 additions & 1 deletion data/mods/gen9ssb/moves.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1376,7 +1376,6 @@ export const Moves: {[k: string]: ModdedMoveData} = {
},
secondary: null,
hasSheerForce: true,

onPrepareHit(target, source) {
this.attrLastMove('[still]');
this.add('-anim', source, 'Lunar Dance', target);
Expand Down

0 comments on commit 412e688

Please sign in to comment.