Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tera Switch Mod #9701

Closed
wants to merge 12 commits into from
Closed

Add Tera Switch Mod #9701

wants to merge 12 commits into from

Conversation

Seerd
Copy link
Contributor

@Seerd Seerd commented Aug 6, 2023

For the forgotten OM: https://www.smogon.com/forums/threads/tera-switch.3715743/
Needs to fix visual bug that prevents Tera icon/type from disappearing when going back to original types, plz help.
EDIT: Fixed the visual bug, needs client stuff tho smogon/pokemon-showdown-client#2144

@MathyFurret
Copy link
Contributor

That's because there isn't a message defined to remove Tera yet. Necessecity's the mother of invention, after all.

@KrisXV
Copy link
Member

KrisXV commented Aug 6, 2023

necessecity

data/rulesets.ts Outdated Show resolved Hide resolved
@Seerd
Copy link
Contributor Author

Seerd commented Aug 14, 2023

Have been trying some stuff without luck, can't figure out how to fix that visual bug.

Co-authored-by: AnnikaCodes <[email protected]>
@MathyFurret
Copy link
Contributor

ok so what you would actually need to do is make a new message type that tells the client to clear a tera. something like -unterastallize|POKEMON

there are 3 parts to this:

  • document the message in SIM-PROTOCOL.md (apparently optional because -terastallize hasn't even been added yet loool)
  • on the client, around here, add a case for your new message that undoes all the stuff that tera does. there's the log text aspect too
  • send the message whenever you un-tera (with this.add)

@Seerd Seerd requested a review from Marty-D as a code owner August 30, 2023 17:56
Seerd added a commit to Seerd/pokemon-showdown-client that referenced this pull request Aug 30, 2023
@Seerd
Copy link
Contributor Author

Seerd commented Aug 30, 2023

Thanks, now it does update the types every turn.

@Seerd Seerd closed this Feb 6, 2024
KrisXV pushed a commit to Seerd/pokemon-showdown-client that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants