Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Leppa Berry #5025

Merged
merged 2 commits into from
Dec 14, 2018
Merged

Fix Leppa Berry #5025

merged 2 commits into from
Dec 14, 2018

Conversation

MathyFurret
Copy link
Contributor

@MathyFurret MathyFurret commented Dec 12, 2018

This fixes #2367 (comment)

If I understand correctly, the Leppa Berry is normally eaten when any move is at 0 PP, and restores 10 PP to the first move with 0 PP. If the Leppa Berry is forcibly eaten through means such as Fling, it restores PP to the first move that has any PP missing. If all moves have full PP, nothing happens.

Thank @SadisticMystic for the research

@Zarel
Copy link
Member

Zarel commented Dec 13, 2018

Is the leppaberry volatile necessary? My theory is that it's "first move with 0 PP if there's at least one move with 0 PP, otherwise first move with any PP missing".

@MathyFurret
Copy link
Contributor Author

I can't say for sure, you'll have to ask someone who can research it

@Zarel
Copy link
Member

Zarel commented Dec 13, 2018

@SadisticMystic?

@SadisticMystic
Copy link
Contributor

In case of Fling/Bug Bite/Pluck, 0 PP does take precedence over an earlier move with some but not all PP missing.

@Zarel
Copy link
Member

Zarel commented Dec 13, 2018

AS I SUSPECTED

@Zarel
Copy link
Member

Zarel commented Dec 14, 2018

image

This is what I like to see.

@Zarel Zarel merged commit eecde00 into smogon:master Dec 14, 2018
@MathyFurret MathyFurret deleted the leppa branch December 14, 2018 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Known Mechanics Bugs
3 participants