Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for challenge codes for past 35 Pokes metagames #10772

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

swordfishtr
Copy link
Contributor

Currently the challenge codes used for challenging to a past 35 Pokes meta look like so: (a couple more samples in this tour post)

/challenge gen9nationaldex35pokes @@@ -All Pokemon, +mabosstiff, +eelektross, +camerupt, +grapploct, +drifblim, +ampharos, +lurantis, +gyarados, +hypno, +druddigon, +durant, +chesnaught, +gastrodon, +eldegoss, +pelipper, +dodrio, +wailord, +emolga, +dachsbun, +drampa, +trevenant, +passimian, +beautifly, +tyranitar, +regirock, +stunfisk-galar, +morpeko, +jumpluff, +heatmor, +froslass, +audino, +cetitan, +pincurchin, +cradily, +ninetales, -Golem-Alola, -Zoroark, -Pyukumuku, -Guzzlord, -Wugtrio, -Garbodor, -Aurorus, -Walrein, -Roserade, -Ribombee, -Carracosta, -Perrserker, -Appletun, -Primarina, -Pachirisu, -Banette, -Celebi, -Avalugg, -Wo-Chien, -Pupitar, -Milotic, -Scovillain, -Dipplin, -Chandelure, -Toxicroak, -Magmortar, -Yanmega, -Cacturne, -Luvdisc, -Mawile, -Rotom-Frost

Pokemon in the current month's roster (that don't overlap with the target meta) have to be individually banned. Considering that most tours take place between 2 months, these challenge codes will have to be adapted according to the next month's roster. It's not convenient for the hosts and the players.

The -allpokemon tag intentionally has the lowest priority in validation, so its default behavior is insufficient for this purpose. This PR does the following:

  • Adds logic handling -allpokemon to the 35 Pokes validator. Its purpose is to allow shorter (and date independant) challenge codes in the form of /challenge gen9nationaldex35pokes @@@ -All Pokemon, +mabosstiff, +eelektross, +camerupt, +grapploct, +drifblim, +ampharos, +lurantis, +gyarados, +hypno, +druddigon, +durant, +chesnaught, +gastrodon, +eldegoss, +pelipper, +dodrio, +wailord, +emolga, +dachsbun, +drampa, +trevenant, +passimian, +beautifly, +tyranitar, +regirock, +stunfisk-galar, +morpeko, +jumpluff, +heatmor, +froslass, +audino, +cetitan, +pincurchin, +cradily, +ninetales

  • Moves the unbanlist definition to the new logic. This is necessary because unbanlist interferes with the challenge code before the validation is reached. Pokemon in unbanlist are interpreted as +pokemon in the rule table, and so +pokemon in the challenge code is removed if present. For instance, Garbodor is part of this month's roster, and that of November 2023 as well. If this month someone was to challenge someone else to Nov 2023 using a code like @@@ -All Pokemon, +Mismagius, +Garbodor, +Swampert, ..., their code would be interpreted as @@@ -All Pokemon, +Mismagius, +Swampert, ..., and any validator logic would be unaware of the player initially specifying +Garbodor.

  • Provide an alternative filter for the client build script. It was previously relying on unbanlist.

This PR makes the 35 Pokes teambuilder display nothing if built again until the complementary patch is applied. I'll link it shortly.

Thank you for checking. Happy holidays!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant