Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add [Gen 9] Draft Factory #10702

Merged
merged 7 commits into from
Dec 4, 2024
Merged

Add [Gen 9] Draft Factory #10702

merged 7 commits into from
Dec 4, 2024

Conversation

Karthik99999
Copy link
Contributor

@Karthik99999 Karthik99999 commented Nov 28, 2024

Supersedes #10213

Instead of messing with databases, this implementation just uses a json file that contains all the matchups in their packed formats. Everything else is the same idea.

Made this a draft pr just in case there were any opinions on using a json file for this. The format itself is fully functional.

@Karthik99999 Karthik99999 marked this pull request as ready for review December 3, 2024 04:10
@KrisXV
Copy link
Member

KrisXV commented Dec 4, 2024

Might be worth writing some tests for EV validation etc in the future, but I won't hold this PR's mergeability on that

@KrisXV KrisXV merged commit b68fc72 into smogon:master Dec 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants