Remove unlinkUser #10101
Merged
Remove unlinkUser #10101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactor removes `player.unlinkUser()` which was used for several unrelated use cases. These have been split apart into: - at the end of a game, `game.setEnded()` now clears `user.games`, while leaving `player.id` untouched - when trying to change the user associated with the player, we now consistently use the higher-level `game.updatePlayer()` There's a good chance this fixes the lagspikes currently affecting PS.
Zarel
added
the
crashes /hotpatch
MathyFurret
pushed a commit
to MathyFurret/pokemon-showdown
that referenced
this pull request
May 21, 2024
This refactor removes `player.unlinkUser()` which was used for several unrelated use cases. These have been split apart into: - at the end of a game, `game.setEnded()` now clears `user.games`, while leaving `player.id` untouched - when trying to change the user associated with the player, we now consistently use the higher-level `game.updatePlayer()` There's a good chance this fixes the lagspikes currently affecting PS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor removes
player.unlinkUser()which was used for several unrelated use cases.These have been split apart into:
game.setEnded()now clearsuser.games, while leavingplayer.iduntouchedgame.updatePlayer()There's a good chance this fixes the lagspikes currently affecting PS.