Refactor STAB (again) #10099
Merged
Refactor STAB (again) #10099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Karthik99999
requested review from
HoeenCoder,
KrisXV and
Marty-D
as code owners
urkerab
reviewed
Jan 8, 2024
|
@Marty-D @DaWoblefet any opinions/input? |
DaWoblefet
approved these changes
Jan 13, 2024
|
Thanks Karthik! |
MathyFurret
pushed a commit
to MathyFurret/pokemon-showdown
that referenced
this pull request
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally was just trying to fix a bug with the pledge moves and tera stellar (combined pledge moves should always be boosted to 2x by tera stellar), but may have gotten a little carried away. Anyway, this changes the STAB code to much more closely resemble the actual STAB code from the games, and introduces a new
ModifySTABevent to further improve the separation and readability of the Adaptability logic.