Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to Best-Of checkbox #2218

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix to Best-Of checkbox #2218

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion play.pokemonshowdown.com/js/client-mainmenu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -949,7 +949,7 @@
if (bestOf && bestOfValue) {
var hasCustomRules = format.includes('@@@');
format += hasCustomRules ? ', ' : '@@@';
format += 'Best of = ' + bestOfValue;
format += '!!Best of = ' + bestOfValue;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be logic here to only add !! if the best of rule already exists?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be logic here to only add !! if the best of rule already exists?

I don't see why it would make a difference personally.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
because of this

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know that was a thing, my bad.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did try to make it conditional but I couldn't really figure out how to make sure it would cover all possible syntaxes for the best-of command, then I thought it wouldn't be needed so I let if be.

}

var team = null;
Expand Down