Fix CSS on downloaded replays #2165
Conversation
|
This would be fixed if we just reverted that, right? |
|
I tested and it does seem to be sufficient. |
PR #2162 removed the CSS on downloaded replays without any explanation. I think it was intended to save space and/or make things bigger? But it came with a number of bugs. - downloaded replay logs are much wider than intended - downloaded replays now have a "battle options" button that does nothing - downloaded replays have some unstyled text in e.g. popups - MOST IMPORTANTLY: downloaded replays are no longer styled when you don't have an internet connection Anyway, reverting that change fixes all these issues, and doesn't seem to cause any new ones? This is a temporary measure while waiting for Karthik to explain why the CSS removal was done in the first place. Refs #2165
|
Okay, I pushed e3b82f2 which fixes the specific bug described in your PR OP. I'm still confused why you removed all the CSS from downloaded replays, so I'm leaving this PR open until you tell me why you made the change and whether any changes still need to be made. |
I just noticed some discrepancies (mainly font size) from the downloaded and online replays, and after I removed all the css I was like "hey it still works" so I just left it like that. I can see why you had it there though, so yeah this pr isn't needed anymore |
PR smogon#2162 removed the CSS on downloaded replays without any explanation. I think it was intended to save space and/or make things bigger? But it came with a number of bugs. - downloaded replay logs are much wider than intended - downloaded replays now have a "battle options" button that does nothing - downloaded replays have some unstyled text in e.g. popups - MOST IMPORTANTLY: downloaded replays are no longer styled when you don't have an internet connection Anyway, reverting that change fixes all these issues, and doesn't seem to cause any new ones? This is a temporary measure while waiting for Karthik to explain why the CSS removal was done in the first place. Refs smogon#2165
I did not notice the Times New Roman font in the tooltips on my other PR.