Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix): hide username on screens smaller than 500px #1973

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

takeshi-codes
Copy link
Contributor

fix for #1943

First PR here, so open to constructive feedback on how to better do this, if this is applicable.

@DaWoblefet
Copy link
Member

Can you provide screenshots of the new behavior? I have a pretty good idea of what it's supposed to be doing but screenshots are always nice :).

@takeshi-codes
Copy link
Contributor Author

@DaWoblefet yeah, sure thing. Thank you for the quick response!
Screen Shot 2022-05-18 at 8 31 36 AM
Screen Shot 2022-05-18 at 8 32 00 AM
Screen Shot 2022-05-18 at 8 32 14 AM

@DaWoblefet
Copy link
Member

DaWoblefet commented May 19, 2022

I personally think this is OK. The only other idea I could think of would be to reduce font-size, or force it to say inside its container and add a text-overflow: ellipsis, or perhaps some combo of the two. As long as the "Choose Name" appears on mobile this solution is good.

Can we call the class something more descriptive? Maybe username-topbar?

@AnnikaCodes
Copy link
Collaborator

I like Wob's idea of using text-overflow: ellipsis; it would solve the navigation problems while still making it somewhat possible for users with multiple accounts to tell which alt they are on at a glance.

@Zarel
Copy link
Member

Zarel commented Mar 6, 2023

I think this change is better than nothing, so if there are no objections, I'd merge for now.

@AnnikaCodes AnnikaCodes merged commit 399aee9 into smogon:master Jul 18, 2023
@AnnikaCodes
Copy link
Collaborator

Hi, sorry about the wait to merge this. It should go live today!

MathyFurret pushed a commit to MathyFurret/pokemon-showdown-client that referenced this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants