Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Items defining their own usefulness and isNonstandard per mod #2156

Open
EnPassant4264 opened this issue Sep 27, 2023 · 0 comments
Open

Items defining their own usefulness and isNonstandard per mod #2156

EnPassant4264 opened this issue Sep 27, 2023 · 0 comments

Comments

@EnPassant4264
Copy link
Contributor

Copy/pasting from the Suggestions thread:

This would add a rating variable to items to be used in making the Popular/regular/specific/usually useless/useless categories, similar to what Abilities have for... I think randbats? Currently, build-indexes is hardcoded for every non-regular item and even runs checks based on generation, which could be moved to the gens' mod folders with this change. The new code would be as easy as a switch statement based on rating with maybe some fall-throughs for Pokemon-specific items.

Additionally, isNonstandard could be set or removed for an item in ModdedItemsData, which requires editing build-indexes and battle-dex-search to create/load the override. Currently, only item descriptions can be changed by mods.

The purpose of these two changes would be allowing mods to create their own item lists in the teambuilder. Mix and Mega, for instance, would appreciate having all the Mega Stones show up at the top rather than only by searching their name and still showing up as Illegal.

I wanted to get approval before implementing it in case it would be rejected for something I don't know well enough to consider, like adding unwanted networking load on battles; that was what happened with my last request. (There will be more of these in the future)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant