feat: add transactions types #285

developerfred · 2024-01-04T23:44:06Z

new transaction type page

how to test

check if the page is rendering accordingly

vercel · 2024-01-04T23:44:10Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
evm-codes	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 30, 2024 2:09pm

dorlevi · 2024-01-08T07:57:26Z

@developerfred : it seems like the build is failing on this branch, are you addressing it?

charisra

Few comments, also please check the failed build.

components/ChainSelector.tsx

components/Reference/columns.tsx

context/ethereumContext.tsx

lib/useActions.tsx

pages/transactions.tsx

2xic · 2024-01-19T19:43:32Z

@developerfred do you need any help addressing the feedback / getting the build to complete ?

developerfred · 2024-01-20T14:48:18Z

@developerfred do you need any help addressing the feedback / getting the build to complete ?

If you could help that would be great too, I can't see the Vercel logs I'm doing typecheck locally

vercel · 2024-01-20T14:49:49Z

@developerfred is attempting to deploy a commit to the smlXL Team on Vercel.

A member of the Team first needs to authorize it.

2xic · 2024-01-22T09:21:17Z

@developerfred do you need any help addressing the feedback / getting the build to complete ?

If you could help that would be great too, I can't see the Vercel logs I'm doing typecheck locally

Sure, attached the command for running the typechecker and how to fix them 😄

Let us know if you still have any issues 🙌

Finding the build error

If you run yarn run typecheck you should see the following two build errors (if you don't make sure you ran yarn install first)

brage@brages-MBP developerfred-evm.codes % yarn run typecheck

> [email protected] typecheck
> tsc --pretty

components/KBar/Results.tsx:8:11 - error TS2339: Property 'results' does not exist on type 'ActionGroup[]'.

8   const { results } = useMatches()
            ~~~~~~~

pages/_app.tsx:38:27 - error TS2322: Type '({ id: string; name: string; shortcut: string[]; keywords: string; section: string; subtitle: string; icon: Element; children: { id: string; name: string; shortcut: string[]; keywords: string; section: string; perform: () => void; subtitle: string; icon: Element; }[]; perform?: undefined; } | { ...; } | { ...; })[]' is not assignable to type 'Action[]'.
  Type '{ id: string; name: string; shortcut: string[]; keywords: string; section: string; subtitle: string; icon: Element; children: { id: string; name: string; shortcut: string[]; keywords: string; section: string; perform: () => void; subtitle: string; icon: Element; }[]; perform?: undefined; } | { ...; } | { ...; }' is not assignable to type 'Action'.
    Type '{ id: string; name: string; shortcut: string[]; keywords: string; section: string; subtitle: string; icon: JSX.Element; children: { id: string; name: string; shortcut: string[]; keywords: string; section: string; perform: () => void; subtitle: string; icon: JSX.Element; }[]; perform?: undefined; }' is not assignable to type 'Action'.
      Types of property 'children' are incompatible.
        Type '{ id: string; name: string; shortcut: string[]; keywords: string; section: string; perform: () => void; subtitle: string; icon: Element; }[]' is not assignable to type 'string[]'.
          Type '{ id: string; name: string; shortcut: string[]; keywords: string; section: string; perform: () => void; subtitle: string; icon: JSX.Element; }' is not assignable to type 'string'.

38             <KBarProvider actions={actions}>
                             ~~~~~~~

  node_modules/kbar/lib/types.d.ts:27:5
    27     actions: Action[];
           ~~~~~~~
    The expected type comes from property 'actions' which is declared here on type 'IntrinsicAttributes & KBarProviderProps & { children?: ReactNode; }'


Found 2 errors in 2 files.

Errors  Files
     1  components/KBar/Results.tsx:8
     1  pages/_app.tsx:38

Fixing components/KBar/Results.tsx:8

So first step would be to fix the error in Results.tsx .

Since useMatches() returns an array we want to switch from

evm.codes/components/KBar/Results.tsx

Line 8 in eb75abc

const { results } = useMatches()

to

const results = useMatches()

Fixing pages/_app.tsx:38

Then fix the issue in pages/_app.tsx where you added a new entry for the theme

(only showing the relevant code entry, but click the link for full context)

evm.codes/lib/useActions.tsx

Lines 13 to 53 in eb75abc

    
           { 
        
             id: 'theme', 
        
             name: 'Theme', 
        
             shortcut: ['t'], 
        
             keywords: 'change theme', 
        
             section: 'Settings', 
        
             subtitle: 'Change application theme', 
        
             icon: <Icon name="palette-line" />, 
        
             children: [ 
        
               { 
        
                 id: 'theme-light', 
        
                 name: 'Light Mode', 
        
                 shortcut: ['l'], 
        
                 keywords: 'light theme', 
        
                 section: 'Settings', 
        
                 perform: () => setTheme('light'), 
        
                 subtitle: 'Switch to Light Mode', 
        
                 icon: <Icon name="sun-line" />, 
        
               }, 
        
               { 
        
                 id: 'theme-dark', 
        
                 name: 'Dark Mode', 
        
                 shortcut: ['d'], 
        
                 keywords: 'dark theme', 
        
                 section: 'Settings', 
        
                 perform: () => setTheme('dark'), 
        
                 subtitle: 'Switch to Dark Mode', 
        
                 icon: <Icon name="moon-line" />, 
        
               }, 
        
               { 
        
                 id: 'theme-system', 
        
                 name: 'System Default', 
        
                 shortcut: ['s'], 
        
                 keywords: 'system theme', 
        
                 section: 'Settings', 
        
                 perform: () => setTheme('system'), 
        
                 subtitle: 'Use system theme settings', 
        
                 icon: <Icon name="settings-2-line" />, 
        
               }, 
        
             ], 
        
           },

The Action type wants just the action id in the children field so you should be able to switch this to

    {
      id: 'theme',
      name: 'Theme',
      shortcut: ['t'],
      keywords: 'change theme',
      section: 'Settings',
      subtitle: 'Change application theme',
      icon: <Icon name="palette-line" />,
      children: [
        'theme-light',
        'theme-dark',
        'theme-system'
      ],
    },
    {
      id: 'theme-light',
      name: 'Light Mode',
      shortcut: ['l'],
      keywords: 'light theme',
      section: 'Settings',
      perform: () => setTheme('light'),
      subtitle: 'Switch to Light Mode',
      icon: <Icon name="sun-line" />,
    },
    {
      id: 'theme-dark',
      name: 'Dark Mode',
      shortcut: ['d'],
      keywords: 'dark theme',
      section: 'Settings',
      perform: () => setTheme('dark'),
      subtitle: 'Switch to Dark Mode',
      icon: <Icon name="moon-line" />,
    },
    {
      id: 'theme-system',
      name: 'System Default',
      shortcut: ['s'],
      keywords: 'system theme',
      section: 'Settings',
      perform: () => setTheme('system'),
      subtitle: 'Use system theme settings',
      icon: <Icon name="settings-2-line" />,
    },

2xic · 2024-01-24T20:42:22Z

@developerfred do you need any more help here - I'm happy to help so we can get this in a reviewable state 😄

…ctions-types

charisra · 2024-01-29T17:15:03Z

@developerfred all you need to for the to fix the build error is replace this:

children: [
  'theme-light',
  'theme-dark',
  'theme-system'
],

with this:
children: ['theme-light', 'theme-dark', 'theme-system']

in: ./lib/useActions.tsx

Want to give this a try and see if it builds? I can help more if you face more problems. Would really help if you got your local ESLint properly setup, if you haven’t already.

developerfred · 2024-01-29T20:17:26Z

Thanks @2xic @dorlevi and @charisra build working now

version working https://evm-codes-fmjmeuoa2-developerfred.vercel.app/transactions

charisra · 2024-01-30T14:03:36Z

Thanks @2xic @dorlevi and @charisra build working now

version working evm-codes-fmjmeuoa2-developerfred.vercel.app/transactions

It's lot letting me preview so can't tell if it's ok @developerfred . I still see errors building in the latest builds. Can you do a check that your latest commits build successfully?

Also, if you're using VSCode, please ensure you have Prettier installed and enabled. It should auto-fix several code formatting errors.

developerfred · 2024-01-30T17:04:51Z

@charisra My commits were compiled, I also used prettier, what are the next steps?

charisra · 2024-01-30T19:33:00Z

@charisra My commits were compiled, I also used prettier, what are the next steps?

Great. I'll review once more, also check the Preview, approve and then you can merge.

charisra

This is going on the right track, close to be merge-able.
@developerfred please add in the PR description a short explanation about what has been done in this PR and how we (reviewers) can test & confirm that the PR achieves its purpose.

Left a few comments, too, should be easy to address.

charisra · 2024-01-31T15:32:57Z

components/Reference/Header.tsx

+  let title = 'Instructions'
+  if (isPrecompiled) {
+    title = 'Precompiled Contracts'
+  }
+  if (isTransactionType) {
+    title = 'Transaction Types'
+  }


Optional: Can become a one-liner: let title = isPrecompiled ? 'Precompiled Contracts' : isTransactionType ? 'Transaction Types' : 'Instructions';

docs/opcodes/16.mdx

docs/opcodes/30.mdx

charisra · 2024-01-31T15:59:07Z

So that's what I'm expected to see?

Just the types, there's not any more info on those, it mentions There is no reference doc for this yet. Why not contribute That's the expected behavior?

developerfred · 2024-01-31T18:04:22Z

There is no reference doc for this yet. Why not contribute That's the expected behavior?

I believe this is a call action to attract contributors

charisra · 2024-02-05T12:51:09Z

@developerfred I approved the PR. Is there anything pending before you merge?

feat: add transactions types

efd04b6

vercel bot had a problem deploying to Preview January 4, 2024 23:44 Failure

feat; add label on transactions types

fa61b4b

vercel bot had a problem deploying to Preview January 5, 2024 00:00 Failure

dorlevi requested review from 2xic and charisra January 8, 2024 07:56

charisra reviewed Jan 8, 2024

View reviewed changes

chore(types): fixed vercel build

a79aa1c

vercel bot had a problem deploying to Preview January 12, 2024 13:09 Failure

Merge branch 'main' into codingsh/add-transactions-types

eb75abc

vercel bot had a problem deploying to Preview January 22, 2024 08:45 Failure

developerfred added 2 commits January 29, 2024 14:05

chore(typecheck): running typecheck

e7e9bbe

Merge remote-tracking branch 'upstream/main' into codingsh/add-transa…

81a1d68

…ctions-types

vercel bot had a problem deploying to Preview January 29, 2024 14:29 Failure

developerfred force-pushed the codingsh/add-transactions-types branch 2 times, most recently from 2217337 to f95cb6f Compare January 29, 2024 14:32

chore(Kbar): results fix

7af0e4b

developerfred force-pushed the codingsh/add-transactions-types branch 6 times, most recently from 502886b to 473370d Compare January 29, 2024 15:28

developerfred force-pushed the codingsh/add-transactions-types branch 2 times, most recently from cbef637 to 58bc312 Compare January 29, 2024 15:37

vercel bot had a problem deploying to Preview January 29, 2024 16:05 Failure

developerfred force-pushed the codingsh/add-transactions-types branch 4 times, most recently from d80e3dc to 9e1231c Compare January 29, 2024 20:09

chore(editor): fixed build types

8dee601

developerfred force-pushed the codingsh/add-transactions-types branch from 9e1231c to 8dee601 Compare January 29, 2024 20:13

developerfred requested a review from charisra January 29, 2024 20:18

chore(style): add rollupStyles on columns

972ba91

vercel bot deployed to Preview January 30, 2024 14:09 View deployment

charisra reviewed Jan 31, 2024

View reviewed changes

charisra approved these changes Jan 31, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add transactions types #285

feat: add transactions types #285

developerfred commented Jan 4, 2024 •

edited

Loading

vercel bot commented Jan 4, 2024 •

edited

Loading

dorlevi commented Jan 8, 2024

charisra left a comment

2xic commented Jan 19, 2024

developerfred commented Jan 20, 2024

vercel bot commented Jan 20, 2024

2xic commented Jan 22, 2024

2xic commented Jan 24, 2024

charisra commented Jan 29, 2024

developerfred commented Jan 29, 2024 •

edited

Loading

charisra commented Jan 30, 2024

developerfred commented Jan 30, 2024

charisra commented Jan 30, 2024

charisra left a comment

charisra Jan 31, 2024

charisra commented Jan 31, 2024 •

edited

Loading

developerfred commented Jan 31, 2024

charisra commented Feb 5, 2024

feat: add transactions types #285

Are you sure you want to change the base?

feat: add transactions types #285

Conversation

developerfred commented Jan 4, 2024 • edited Loading

new transaction type page

how to test

vercel bot commented Jan 4, 2024 • edited Loading

dorlevi commented Jan 8, 2024

charisra left a comment

Choose a reason for hiding this comment

2xic commented Jan 19, 2024

developerfred commented Jan 20, 2024

vercel bot commented Jan 20, 2024

2xic commented Jan 22, 2024

Finding the build error

Fixing components/KBar/Results.tsx:8

Fixing pages/_app.tsx:38

2xic commented Jan 24, 2024

charisra commented Jan 29, 2024

developerfred commented Jan 29, 2024 • edited Loading

charisra commented Jan 30, 2024

developerfred commented Jan 30, 2024

charisra commented Jan 30, 2024

charisra left a comment

Choose a reason for hiding this comment

charisra Jan 31, 2024

Choose a reason for hiding this comment

charisra commented Jan 31, 2024 • edited Loading

developerfred commented Jan 31, 2024

charisra commented Feb 5, 2024

developerfred commented Jan 4, 2024 •

edited

Loading

vercel bot commented Jan 4, 2024 •

edited

Loading

developerfred commented Jan 29, 2024 •

edited

Loading

charisra commented Jan 31, 2024 •

edited

Loading