-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace sharelatex to overleaf in AuthenticationController.js.diff #51
base: master
Are you sure you want to change the base?
Conversation
according to https://github.com/overleaf/overleaf/wiki/Release-Notes-5.x.x#configuration-changes , the environment variable like "SHARELATEX_*" have been renamed to "OVERLEAF_*".
Great work! However, we're still at version 4.2.0, haha. We'll proceed with merging this after we upgrade to version 5.0.1. |
The most important change in the release upgrade from version 4.x.x to 5.x.x is the upgrade of mongodb (version 4 to 5). I think we have to test before we propose an upgrade on existing instances (I assume there will be no major issues but still). More important we have to adjust all configuration files - which is missing in your pull request. Additionally, the Dockerfile has to be updated to version 5.0.1 and then we have to check the ldap authentication as well. We should have a look at the changes which davrot did (master...davrot:ldap-overleaf-sl:master) to run version 5 (see also Issue #50 ). |
Understood. A few days ago, I attempted to upgrade our organization's Overleaf instance, which manages about 20,000 projects and is configured with LDAP and OAuth2, from version 4.2 to 5. Upgrading MongoDB was quite straightforward: before updating the MongoDB Docker image, you simply need to execute a command like db.adminCommand({ setFeatureCompatibilityVersion: "4.4" }) in the MongoDB shell. For example, we upgraded MongoDB from 4.0 (used by ShareLaTeX 3.x) to 5.0 by following these steps (all MongoDB migrations were executed using the sharelatex:4.2.0 Docker image, and we referenced the Overleaf wiki):
I hope this helps! |
According to my upgrade log, it seems that the only additional requirement beyond the standard upgrade process is updating the TeX Live version from 2023 to 2024. I suspect that Overleaf might use TeX Live 2024 in their next v5 release. Apart from this, no other configuration changes are necessary. All features provided by ldap-overleaf-sl continue to function as expected after the upgrade. Our mofications: https://mirrors.sustech.edu.cn/git/sustech-cra/overleaf-ldap-oauth2/-/commit/36e334be18cc6b04cd31323d06d677a10ed94d95 |
I started an installation from the scratch using the current ldap-overleaf-sl (for 4.2.0) bash scripts/extract_files.sh 5.0.1 bash scripts/extract_files.sh 4.2.0 .env Dockerfile:
AuthenticationController.js ( in the patched version)
make docker-compose.yml
// substitute attributes which start with SHARELATEX to OVERLEAF
|
I guess the issue may caused by the version incompatible between the current texlive and the texlive from the ubuntu package manager (apt), as https://packages.ubuntu.com/search?suite=all&searchon=names&keywords=texlive-full indicates that the texlive-full package in the ubuntu 22.04 is Texlive 2021, but the texlive version in the docker image is 2023. It might be a better choice to upgrade the texlive by following the instructions on https://www.tug.org/texlive/upgrade.html . |
according to https://github.com/overleaf/overleaf/wiki/Release-Notes-5.x.x#configuration-changes , the environment variable like "SHARELATEX_" have been renamed to "OVERLEAF_" on sharelatex image >=5.0.1