feat: find dsyms in folders

smartlook · Feb 9, 2023 · 85e33a4 · 85e33a4
1 parent eb099b2
commit 85e33a4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 8 deletions.
diff --git a/src/lib/commands/upload-mapping-file/upload-mapping-file.ts b/src/lib/commands/upload-mapping-file/upload-mapping-file.ts
@@ -1,22 +1,17 @@
-import archiver from 'archiver'
 import * as fs from 'fs'
 import * as plist from 'plist'
 import * as path from 'node:path'
-import * as os from 'node:os'
-import { execSync } from 'node:child_process'
 import glob from 'glob'
 import {
 	AppIdentifiers,
 	CLIArgs,
-	IDSymInfo,
 	IXCarchiveInfoPlistFile,
 	IApplicationProperties,
 	RequestOptions,
 } from './types'
 import { uploadAndroid, uploadApple } from './uploaders'
 
 import { debug, error, info } from '../../logger'
-import { isXcarchive } from './helpers'
 import { upload } from './upload'
 import { ValidationError } from '../../ValidationError'
 

diff --git a/src/lib/commands/upload-mapping-file/uploaders/upload-apple.ts b/src/lib/commands/upload-mapping-file/uploaders/upload-apple.ts
@@ -8,7 +8,7 @@ import archiver from 'archiver'
 import FormData from 'form-data'
 
 import { error, info, debug } from '../../../logger'
-import { isXcarchive } from '../helpers'
+import { isDsym } from '../helpers'
 import { CLIArgs, IDSymInfo, RequestOptions } from '../types'
 
 function getDsymPaths(basePath: string): string[] {
@@ -113,10 +113,10 @@ function extractDsymInfo(dsymPath: string): IDSymInfo | null {
 async function extractAndPackDsyms(basePath: string) {
 	const dsymPaths: string[] = []
 
-	if (!isXcarchive(basePath)) {
+	if (isDsym(basePath)) {
 		dsymPaths.push(basePath)
 	} else {
-		info('.xcarchive detected - extracting dSYMs')
+		info('looking for dSYMs')
 
 		const discoveredDSyms = getDsymPaths(basePath)
 		dsymPaths.push(...discoveredDSyms)