Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: sdp resend feature #667

Merged
merged 14 commits into from
Aug 6, 2024
Merged

Conversation

Morg42
Copy link
Member

@Morg42 Morg42 commented Aug 1, 2024

No description provided.

Copy link
Member Author

@Morg42 Morg42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wenn die Implementation für dich so funktioniert, dann okay.

Kannst du im Quelltext ggf. die Methoden noch etwas mehr kommentieren, zB _check_commands und resend, sowohl im """-Header als auch im Code?

lib/model/smartdeviceplugin.py Outdated Show resolved Hide resolved
lib/model/smartdeviceplugin.py Outdated Show resolved Hide resolved
lib/model/sdp/connection.py Outdated Show resolved Hide resolved
lib/model/sdp/connection.py Outdated Show resolved Hide resolved
lib/model/sdp/protocol.py Outdated Show resolved Hide resolved
@Morg42 Morg42 marked this pull request as ready for review August 6, 2024 17:44
@Morg42 Morg42 merged commit dd4ec55 into smarthomeNG:develop Aug 6, 2024
5 checks passed
@onkelandy onkelandy deleted the sdp_resend branch August 11, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants