-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
githubplugin: install and remove plugins from foreign GitHub repos #970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onkelandy
requested changes
Nov 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is still one issue when deleting one plugin. Mostly only happens once (after restart). Testes it with this PR, at least on 2nd try I get this error (again).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wie von @bmxp gewünscht, ermöglicht es dieses Plugin, andere Plugins aus fremden Repositories (Forks von smarthomeNG/plugins) herunterzuladen und zu installieren (und wieder zu löschen). Das kann das Ausprobieren, Testen und ggf. das Mitarbeiten an fremden Plugins vereinfachen.
Das gewünschte Repo kann über offene Pull Requests gegen smarthomeNG/plugins oder durch Auswahl des entsprechenden Forks und des Branches ausgewählt werden. Diese Daten werden jeweils von GitHub abgerufen. Das zu installierende Plugin wird als letztes ausgewählt.
Alle Interaktion erfolgen über das Web-Interface. Es können auch unterschiedliche Branches desselben Repositories parallel installiert werden, sofern das gewünscht ist. Durch die Verwendung von Worktrees wird dabei soweit wie möglich belegter Festplattenplatz eingespart.
Achtung: das Plugin nutzt (Unix-)Symlinks und ist nicht unter Windows getestet. Ich bitte daher, unter Windows die Installation und v.a. das Anlegen der Symlinks
plugins/priv_<name>
->plugins/priv_repos/<owner>_wt_<branch>/<plugin>
zu prüfen. Ggf. muss da eine funktionierende Alternative für Windows eingebaut werden!offen: WebIf Übersetzung hinzufügen