Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes issue #28 #31

Merged
merged 11 commits into from
Aug 20, 2024
Merged

Closes issue #28 #31

merged 11 commits into from
Aug 20, 2024

Conversation

zeuslawyer
Copy link
Contributor

What

Issue: https://github.com/orgs/smartcontractkit/projects/17/views/1?pane=issue&itemId=74252721

Why

Planned upgrade as per the board.

NOTES:

  • have added /lib to gitignore and added forge install commands for the dependencies. Tests are still passing.

@zeuslawyer
Copy link
Contributor Author

#28

@zeuslawyer zeuslawyer changed the title Isds https://github.com/smartcontractkit/foundry-starter-kit/issues/28 Aug 15, 2024
@zeuslawyer zeuslawyer changed the title https://github.com/smartcontractkit/foundry-starter-kit/issues/28 For issue #28 Aug 15, 2024
@zeuslawyer zeuslawyer requested a review from andrejrakic August 15, 2024 06:23
- To get the latest of each, just run `foundryup`

And you probably already have `make` installed... but if not [try looking here.](https://askubuntu.com/questions/161104/how-do-i-install-make)
- [Git](https://git-scm.com/book/en/v2/Getting-Started-Installing-Git)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note several format changes without actual content changes.

@zeuslawyer zeuslawyer changed the title For issue #28 Closes issue #28 Aug 19, 2024
@zeuslawyer zeuslawyer requested a review from thodges-gh August 19, 2024 04:49
README.md Outdated Show resolved Hide resolved
lib/solmate Outdated Show resolved Hide resolved
@zeuslawyer zeuslawyer requested a review from thodges-gh August 20, 2024 01:39
@zeuslawyer zeuslawyer merged commit f929075 into main Aug 20, 2024
1 check passed
@zeuslawyer zeuslawyer deleted the zp-issue#28 branch August 20, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants