Refactor DefaultCapConfig into multiple funcs
#15882
Conversation
AER Report: CI Coreaer_workflow , commit , Detect Changes , Clean Go Tidy & Generate , Scheduled Run Frequency , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_fuzz) , Core Tests (go_core_race_tests) , GolangCI Lint (deployment) , test-scripts , lint , SonarQube Scan 1. File is not
|
| } | ||
|
|
||
| func FromCapabilitiesRegistryCapability(cap *capabilities_registry.CapabilitiesRegistryCapability, e deployment.Environment, registryChainSelector uint64) (*RegisteredCapability, error) { | ||
| type RegisteredCapabilityConfig struct { | ||
| DefaultConfig map[string]any |
There was a problem hiding this comment.
this doesn't seem right. is the config serialized to the chain?
| ExecutableConfig *RegisteredCapabilityRemoteExecutableConfig | ||
| } | ||
|
|
||
| type RegisteredCapabilityRemoteTriggerConfig struct { |
There was a problem hiding this comment.
how are you determining this type? is there some more basic building-block type that we can use?
| BatchCollectionPeriod time.Duration | ||
| } | ||
|
|
||
| type RegisteredCapabilityRemoteTargetConfig struct { |
| RequestHashExcludedAttributes: []string{"signed_report.Signatures"}, // TODO: const defn in a common place | ||
| }, | ||
| func GetTriggerCapConfig(refresh time.Duration, expiry time.Duration, minResponsesToAggregate uint32, defaultCfg map[string]any) (*capabilitiespb.CapabilityConfig, error) { | ||
| dCfg, err := values.WrapMap(defaultCfg) |
There was a problem hiding this comment.
better to have the caller pass a values.Map (or what ever the
| }, nil | ||
| } | ||
|
|
||
| func GetConsensusCapConfig(defaultCfg map[string]any) (*capabilitiespb.CapabilityConfig, error) { |
There was a problem hiding this comment.
these functions are odd - they do very little and add little abstraction. why bother? the shouldn't be public, at minimum.
| } | ||
|
|
||
| func FromCapabilitiesRegistryCapability(cap *capabilities_registry.CapabilitiesRegistryCapability, e deployment.Environment, registryChainSelector uint64) (*RegisteredCapability, error) { | ||
| func FromCapabilitiesRegistryCapability(capReg *capabilities_registry.CapabilitiesRegistryCapability, e deployment.Environment, registryChainSelector uint64, cfg []byte) (*RegisteredCapability, error) { |
There was a problem hiding this comment.
this should take the proto object and do the conversation to bytes rather then take bytes
|
Requires
Supports