-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for solana on home chain #15826
base: develop
Are you sure you want to change the base?
Conversation
AER Report: CI Coreaer_workflow , commit , Clean Go Tidy & Generate , Detect Changes , Scheduled Run Frequency , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_fuzz) , GolangCI Lint (core/scripts) , GolangCI Lint (.) , Core Tests (go_core_race_tests) , GolangCI Lint (integration-tests/load) , test-scripts , GolangCI Lint (integration-tests) , GolangCI Lint (deployment) , lint , SonarQube Scan 1. Linting errors detected[Golang Lint (deployment)] [2025-01-09T21:11:46.2492294Z] commentFormatting: put a space between Source of Error://ccip_router.SetProgramID(pub) [Golang Lint (deployment)] [2025-01-09T21:11:46.2496456Z] commentFormatting: put a space between Source of Error://ccip_receiver.SetProgramID(pub) [Golang Lint (deployment)] [2025-01-09T21:11:46.2499102Z] commentFormatting: put a space between Source of Error://token_pool.SetProgramID(pub) [Golang Lint (deployment)] [2025-01-09T21:11:46.2500750Z] appendAssign: append result not assigned to the same slice (gocritic) Source of Error:selectors := append(evmSelectors, solChainSelectors...) [Golang Lint (deployment)] [2025-01-09T21:11:46.2504063Z] File is not Source of Error:"github.com/gagliardetto/solana-go" [Golang Lint (deployment)] [2025-01-09T21:11:46.2504930Z] File is not Source of Error:solana "github.com/gagliardetto/solana-go" [Golang Lint (deployment)] [2025-01-09T21:11:46.2506693Z] File is not Source of Error:chain_selectors "github.com/smartcontractkit/chain-selectors" [Golang Lint (deployment)] [2025-01-09T21:11:46.2510054Z] G115: integer overflow conversion int -> uint8 (gosec) Source of Error:FChain: uint8(len(nodes.NonBootstraps().PeerIDs()) / 3), [Golang Lint (deployment)] [2025-01-09T21:11:46.2513234Z] Consider pre-allocating Source of Error:var ocr3Configs []MultiOCR3BaseOCRConfigArgsSolana [Golang Lint (deployment)] [2025-01-09T21:11:46.2516257Z] indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (revive) Source of Error:} else {
e.Logger.Infow("Confirmed instruction", "instruction", instruction)
} [Golang Lint (deployment)] [2025-01-09T21:11:46.2519693Z] var-naming: var p2pIds should be p2pIDs (revive) Source of Error:p2pIds := nodes.NonBootstraps().PeerIDs() [Golang Lint (deployment)] [2025-01-09T21:11:46.2522191Z] var-naming: var ccipRouterId should be ccipRouterID (revive) Source of Error:ccipRouterId := state.SolChains[chainSel].SolCcipRouter [Golang Lint (deployment)] [2025-01-09T21:11:46.2524663Z] var-naming: var ccipRouterId should be ccipRouterID (revive) Source of Error:ccipRouterId := solChains[remote].SolCcipRouter [Golang Lint (deployment)] [2025-01-09T21:11:46.2526752Z] unnecessary conversion (unconvert) Source of Error:uint8(arg.OcrPluginType), [Golang Lint (deployment)] [2025-01-09T21:11:46.2529381Z] unnecessary conversion (unconvert) Source of Error:IsSignatureVerificationEnabled: uint8(btoi(arg.IsSignatureVerificationEnabled)), [Golang Lint (deployment)] [2025-01-09T21:11:46.2532017Z] unnecessary trailing newline (whitespace) Source of Error:[Golang Lint (deployment)] [2025-01-09T21:11:46.2533664Z] unnecessary trailing newline (whitespace) Source of Error:[Golang Lint (deployment)] [2025-01-09T21:11:46.2535260Z] unnecessary trailing newline (whitespace) Source of Error:[Golang Lint (deployment)] [2025-01-09T21:11:46.2538163Z] non-wrapping format verb for fmt.Errorf. Use Source of Error:return deployment.ChangesetOutput{}, fmt.Errorf("failed to generate instructions: %v", err) [Golang Lint (deployment)] [2025-01-09T21:11:46.2542877Z] non-wrapping format verb for fmt.Errorf. Use Source of Error:return deployment.ChangesetOutput{}, fmt.Errorf("failed to confirm instructions: %v", err) [Golang Lint (deployment)] [2025-01-09T21:11:46.2547360Z] non-wrapping format verb for fmt.Errorf. Use Source of Error:return fmt.Errorf("failed to save address: %v", err) [Golang Lint (deployment)] [2025-01-09T21:11:46.2551886Z] printf: non-constant format string in call to (github.com/smartcontractkit/chainlink/v2/core/logger.Logger).Infof (govet) Source of Error:lggr.Infof(fmt.Sprintf("%+v", sourceChainStateAccount.State)) [Golang Lint (deployment)] [2025-01-09T21:11:46.2554360Z] bool-compare: use require.True (testifylint) Source of Error:require.Equal(t, true, sourceChainStateAccount.Config.IsEnabled) 2. Test failures detected[Run tests] [2025-01-09T21:15:09.3503227Z] Test failures Source of Error:
3. Uncommitted changes detected[Ensure clean after generate] [2025-01-09T21:15:40.8087852Z] Uncommitted changes detected Source of Error:
AER Report: Operator UI CI ran successfully ✅ |
deployment/ccip/changeset/state.go
Outdated
|
||
// ValidateState validates the state of the CCIP deployment | ||
func (s CCIPOnChainState) ValidateState(chainSelector uint64) error { | ||
if deployment.IsSolanaChainFamily(chainSelector) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: maybe just inline this and use switch
/case
? We'll be adding more conditionals here as chains are added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah good idea
…nlink into solana-state-updates
…ainlink into solana-router-deploy
…nlink into solana-link-deploy
…nlink into solana-state-updates
…solana-state-updates
…ainlink into solana-memory-node
I see you updated files related to
|
Quality Gate failedFailed conditions See analysis details on SonarQube Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
https://smartcontract-it.atlassian.net/browse/INTAUTO-381
Requires
Supports
#15726