Ccip-4693 deprecate add lane replaced with granular changesets #15784
Conversation
| _ deployment.ChangeSet[UpdateRouterRampsConfig] = UpdateRouterRamps | ||
| _ deployment.ChangeSet[UpdateFeeQuoterDestsConfig] = UpdateFeeQuoterDests | ||
| _ deployment.ChangeSet[SetOCR3OffRampConfig] = SetOCR3OffRamp | ||
| _ deployment.ChangeSet[UpdateFeeQuoterPricesConfig] = UpdateFeeQuoterPricesCS |
There was a problem hiding this comment.
Appending CS at the end of changesets. otherwise in lot of places the CS and deploy/config funcs are throwing lint error for having same name
AnieeG
requested review from
winder,
rstout,
asoliman92,
makramkd,
dimkouv,
0xAustinWang and
0xnogo
…ccip-4693-deprecate-add-lane
Flakeguard SummaryRan new or updated tests between View Flaky Detector Details | Compare Changes Found Flaky Tests ❌
ArtifactsFor detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json. |
| type NonceManagerUpdate struct { | ||
| AddedAuthCallers []common.Address | ||
| RemovedAuthCallers []common.Address | ||
| PreviousRampsArgs []nonce_manager.NonceManagerPreviousRampsArgs |
There was a problem hiding this comment.
I think in some cases we can we can look up the relevant addresses instead of passing them to make it more robust. Here I think it'll be simpler if we expose just a boolean flag like EnablePrevRamps (and perhaps a DisablePrevRamps flag which would set them to zero) which would look up the relevant prev ramps on the chain (and fail if there are no such legacy ramps). Similar to the approach I took for the TestRouter bool, that way you can't mess it up
| @@ -167,6 +307,143 @@ func UpdateOnRampsDests(e deployment.Environment, cfg UpdateOnRampDestsConfig) ( | |||
| }}, nil | |||
| } | |||
|
|
|||
| type UpdateFeeQuoterPricesConfig struct { | |||
| InitialPrices map[uint64]FeeQuoterPriceUpdatePerSource | |||
There was a problem hiding this comment.
not initial right, just prices to set?
| if chainState.FeeQuoter == nil { | ||
| return fmt.Errorf("missing fee quoter for chain %d", chainSel) | ||
| } | ||
| if err := commoncs.ValidateOwnership(e.GetContext(), cfg.MCMS != nil, e.Chains[chainSel].DeployerKey.From, chainState.Timelock.Address(), chainState.FeeQuoter); err != nil { |
There was a problem hiding this comment.
I think we'd also need to check that the timelock or deployerkey is enabled as a price updater
|
Requires
Supports