Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable debug+info logs by default for legacy mercury jobs #15771

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

samsondav
Copy link
Collaborator

Requires

Supports

@samsondav samsondav requested review from a team as code owners December 19, 2024 13:49
@samsondav samsondav requested a review from jmank88 December 19, 2024 13:49
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

@samsondav samsondav added build-test-image Will build the e2e test image in integration-tests workflow for PRs build-publish Build and Publish image to SDLC labels Dec 19, 2024
@cl-sonarqube-production
Copy link

Copy link
Contributor

AER Report: CI Core

aer_workflow , commit , Clean Go Tidy & Generate , Detect Changes , Scheduled Run Frequency , Flakeguard Root Project / Get Tests To Run , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , GolangCI Lint , Core Tests (go_core_ccip_deployment_tests) , Flakeguard Deployment Project , test-scripts , Core Tests (go_core_fuzz) , Core Tests (go_core_race_tests) , Flakeguard Root Project / Run Tests , Flakeguard Root Project / Report , lint , Flakey Test Detection , SonarQube Scan

1. Test failures in go_core_tests_integration job

Source of Error:

<details>
<summary><b>Source of Error:</b></summary>

```plaintext
Run tests	2024-12-19T14:18:34.2932546Z FAIL	github.com/smartcontractkit/chainlink/v2/core/internal/features/ocr2/plugins	600.312s
Run tests	2024-12-19T14:18:34.2932920Z ok 	github.com/smartcontractkit/chainlink/v2/core/services/ocr2/plugins/mercury	117.640s
Run tests	2024-12-19T14:18:34.2933005Z FAIL
Run tests	2024-12-19T14:18:34.2933014Z 
Run tests	2024-12-19T14:18:34.2933182Z ----------------------------------------------
Run tests	2024-12-19T14:18:34.2933190Z 
Run tests	2024-12-19T14:18:34.2933392Z Beginning check of output logs for sensitive strings
Run tests	2024-12-19T14:18:34.2933772Z No matches in test log output against known set of sensitive strings
Run tests	2024-12-19T14:18:34.2933869Z Exit code: 1
Run tests	2024-12-19T14:18:34.2933991Z Encountered test failures.
Run tests	2024-12-19T14:18:34.2934136Z go_core_tests exiting with code 1
Run tests	2024-12-19T14:18:34.2943261Z ##[error]Process completed with exit code 1.

Why: The test suite for github.com/smartcontractkit/chainlink/v2/core/internal/features/ocr2/plugins failed, causing the overall test run to exit with code 1.

Suggested fix: Investigate the specific test cases within ocr2/plugins that failed. Review the test logs for detailed error messages and stack traces to identify the root cause of the failures.

2. Permission denied for golangci-lint report

Source of Error:

<details>
<summary><b>Source of Error:</b></summary>

```plaintext
Golang Lint ()	2024-12-19T14:07:17.4865008Z level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix / does not contain main module or its selected dependencies"
Golang Lint ()	2024-12-19T14:07:17.4866431Z level=error msg="Running error: can't create output for golangci-lint-report.xml: open golangci-lint-report.xml: permission denied"
Golang Lint ()	2024-12-19T14:07:17.4867165Z 
Golang Lint ()	2024-12-19T14:07:17.4898285Z ##[error]golangci-lint exit with code 3
Golang Lint ()	2024-12-19T14:07:17.4899066Z Ran golangci-lint in 118ms
Golang Lint ()	2024-12-19T14:07:17.4899842Z ##[endgroup]
Golang Lint ()	2024-12-19T14:07:17.5012870Z ##[group]Run cat .//golangci-lint-report.xml
Golang Lint ()	2024-12-19T14:07:17.5013392Z �[36;1mcat .//golangci-lint-report.xml�[0m
Golang Lint ()	2024-12-19T14:07:17.5050397Z shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
Golang Lint ()	2024-12-19T14:07:17.5051058Z ##[endgroup]
Golang Lint ()	2024-12-19T14:07:17.5117437Z cat: .//golangci-lint-report.xml: No such file or directory
Golang Lint ()	2024-12-19T14:07:17.5123228Z ##[error]Process completed with exit code 1.

Why: The golangci-lint action failed due to a permission error when trying to create the golangci-lint-report.xml file. This could be due to insufficient permissions in the working directory.

Suggested fix: Ensure the directory where golangci-lint is trying to write the report has the correct permissions. You may need to adjust the directory permissions or change the working directory to one where the action has write access.

@samsondav samsondav added this pull request to the merge queue Dec 19, 2024
Merged via the queue into develop with commit 6b21c9f Dec 19, 2024
171 of 176 checks passed
@samsondav samsondav deleted the quieten_ocr_logging_mercury branch December 19, 2024 14:46
samsondav added a commit that referenced this pull request Dec 19, 2024
* Disable debug+info logs by default for legacy mercury jobs (#15771)

* Fix restore of config in blue-green mode

The OCR3 database must be scoped to each instance, not to the job,
otherwise we can restore the wrong config on node restart.

* disabling linter on database parameter

---------

Co-authored-by: Sam <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-publish Build and Publish image to SDLC build-test-image Will build the e2e test image in integration-tests workflow for PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants