Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preperation for register unregister execution capability #15760

Merged

Conversation

ettec
Copy link
Collaborator

@ettec ettec commented Dec 18, 2024

To minimise the changeset for PR #15593 all cosmetic changes for the PR are done here, no logic has changed in this PR.

The cosmetic changes are:

common bump
move aggregator to own package
move message cache to own package
apply latest lint rules to all files in remote package.

@ettec ettec marked this pull request as ready for review December 18, 2024 17:09
@ettec ettec requested review from a team as code owners December 18, 2024 17:09
@ettec ettec requested a review from pavel-raykov December 18, 2024 17:09
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

@ettec ettec requested a review from a team as a code owner December 18, 2024 17:13
Copy link
Contributor

github-actions bot commented Dec 18, 2024

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

bolekk
bolekk previously approved these changes Dec 18, 2024
bolekk
bolekk previously approved these changes Dec 18, 2024
@ettec ettec enabled auto-merge December 18, 2024 18:44
@justinkaseman justinkaseman self-requested a review December 18, 2024 18:48
@ettec ettec added this pull request to the merge queue Dec 18, 2024
Merged via the queue into develop with commit a01ed0f Dec 18, 2024
173 of 175 checks passed
@ettec ettec deleted the preperation-for-register-unregister-execution-capability branch December 18, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants