[CAPPL-402] correctly propagate errors on fetcher #15758
Conversation
AER Report: CI Coreaer_workflow , commit , Detect Changes , Clean Go Tidy & Generate , Scheduled Run Frequency , Flakeguard Root Project / Get Tests To Run , lint , Core Tests (go_core_tests) , Flakeguard Deployment Project , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_race_tests) , Core Tests (go_core_fuzz) , Flakeguard Root Project / Run Tests (github.com/smartcontractkit/chainlink/v2/core/services/workflows/syncer, ubuntu-latest) , Flakey Test Detection , SonarQube Scan , Flakeguard Root Project / Report 1. Error parsing test results[Run tests with flakeguard] [2024-12-18T16:38:49.3003614Z] [Error running tests: failed to parse test results: failed to attribute panic to test, using regex syncer.(Test[^\.\(]+) on these strings:] Source of Error:Run tests with flakeguard 2024-12-18T16:38:49.3003614Z Error running tests: failed to parse test results: failed to attribute panic to test, using regex syncer\.(Test[^\.\(]+) on these strings:
Run tests with flakeguard 2024-12-18T16:38:49.3005564Z panic: Log in goroutine after Test_workflowRegisteredHandler/skips_fetch_if_config_url_is_missing has completed: 2024-12-18T16:38:49.173Z DEBUG CapabilitiesRegistry capabilities/registry.go:69 get capability {"version": "unset@unset", "id": "[email protected]"}Why: The error occurred because a panic was logged after the test Suggested fix: Ensure that no logging or operations occur after a test has completed. Review the test and related code to ensure all operations are properly synchronized and completed within the test's lifecycle. AER Report: Operator UI CI ran successfully ✅ |
| @@ -100,5 +100,9 @@ func (s *FetcherService) Fetch(ctx context.Context, url string) ([]byte, error) | |||
| return nil, err | |||
| } | |||
|
|
|||
| if payload.ExecutionError { | |||
| return nil, fmt.Errorf("execution error from gateway: %v", payload.ErrorMessage) | |||
There was a problem hiding this comment.
Nit: use %s rather than %v here
There was a problem hiding this comment.
😅 forgot to change that one, done! thanks
agparadiso
force-pushed
the
CAPPL-402_propagate_error_downloading_artifacts
branch
from
2d25f6e to
2dfc60b
Compare
agparadiso
deleted the
CAPPL-402_propagate_error_downloading_artifacts
branch
Description
Whenever the fetcher was failing to download the artifacts (EG: response payload too big) we where not checking for the error in the payload, aside from that we were also logging the wrong error.
CAPPL-402
Requires
Supports