-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CCIP-4659 New Modified ERC165Checker library #15743
Conversation
Solidity Review Jira issueHey! We have taken the liberty to link this PR to a Jira issue for Solidity Review. This is a new feature, that's currently in the pilot phase, so please make sure that the linkage is correct. In a contrary case, please update it manually in JIRA and replace Solidity Review issue key in the changeset file with the correct one. Any changes to the Solidity Review Jira issue should be reflected in the changeset file. If you need to update the issue key, please do so manually in the following changeset file: This PR has been linked to Solidity Review Jira issue: CCIP-3966 |
Static analysis results are availableHey @jhweintraub, you can view Slither reports in the job summary here or download them as artifact here. |
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
0c13696
to
477f94c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you show how you got to 32k (or 31k as the comment suggests)?
I see you added a changeset file but it does not contain a tag. Please edit the text include at least one of the following tags:
|
0413369
to
435d955
Compare
Quality Gate passedIssues Measures |
To prevent issues with the OZ ERC165Checker's enforcement of 32k gas on external calls, this library adds a check that enough gas exists before making the call, and reverts if it does not.
The OffRamp will use this version of the supportsInterface library to prevent message delivery issues.
The 31k gas requirement was chosen due to the 63/64 gas rule and that the staticcall required 30k gas.