Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully fail if CL_DATABASE_URL is not set #15741

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

pavel-raykov
Copy link
Collaborator

Before this change running an integration test without CL_DATABASE_URL results in panic:

--- FAIL: Test_CCIPBatching_SingleSource (0.06s)
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference

After this change we get a verbose message:

        	Error:      	Received unexpected error:
        	            	path missing from database URL
        	Test:       	Test_CCIPBatching_SingleSource

@pavel-raykov pavel-raykov marked this pull request as ready for review December 18, 2024 15:55
@pavel-raykov pavel-raykov requested review from a team as code owners December 18, 2024 15:55
@pavel-raykov pavel-raykov added this pull request to the merge queue Dec 19, 2024
Merged via the queue into develop with commit 37d3081 Dec 19, 2024
170 checks passed
@pavel-raykov pavel-raykov deleted the graceful-db branch December 19, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants