Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully fail if CL_DATABASE_URL is not set. #15740

Closed
wants to merge 6 commits into from

Conversation

pavel-raykov
Copy link
Collaborator

@pavel-raykov pavel-raykov commented Dec 17, 2024

Before this change running an integration test without CL_DATABASE_URL results in panic:

--- FAIL: Test_CCIPBatching_SingleSource (0.06s)
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference

After this change we get a verbose message:

        	Error:      	Received unexpected error:
        	            	path missing from database URL
        	Test:       	Test_CCIPBatching_SingleSource

@pavel-raykov pavel-raykov deleted the test-db-setup branch December 19, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant